Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests: Add a test that weights file generates different results per player correctly #3392

Merged
merged 5 commits into from
Oct 30, 2024
Merged

Tests: Add a test that weights file generates different results per player correctly #3392

merged 5 commits into from
Oct 30, 2024

Conversation

alwaysintreble
Copy link
Collaborator

What is this fixing or adding?

Adds a test generating with a weights file and makes sure the players get specific different results

How was this tested?

Tested against #3381

@github-actions github-actions bot added the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label May 24, 2024
@alwaysintreble alwaysintreble added is: enhancement Issues requesting new features or pull requests implementing new features. labels May 24, 2024
black-sliver
black-sliver approved these changes Oct 30, 2024
View reviewed changes
Copy link
Member

@black-sliver black-sliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll see how soon this breaks. :-D

I think the alternative would be checking if any rolled value is different than the one for Player1.

@black-sliver black-sliver merged commit f00975c into ArchipelagoMW:main Oct 30, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@black-sliver black-sliver black-sliver approved these changes

Assignees
No one assigned
Labels
is: enhancement Issues requesting new features or pull requests implementing new features. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alwaysintreble @black-sliver