SM and SMZ3 option_definitions deprecation fix #3372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and done some cleaning
…er's" This reverts commit fb3ca18.
- fixed seeded generation - fixed broken logic when more than one SM world - added missing rules for inter-area transitions - added basic patch presence for logic - added DoorManager init call to reflect present patches for logic - moved CollectionState addition out of BaseClasses into SM world - added condition to apply progitempool presorting only if SM world is present - set Bosses item id to None to prevent them going into multidata - now use get_game_players
…VariaRandomizer's rules, items, locations and accessPoint (as regions)
…se (fills ROM item table) This is dependant on modifications done to sm_randomizer_rom project
- player name inject in ROM and get in client - end game get from ROM in client - send self item to server - add player names table in ROM
…ition of an array of it (required to generation more than one SM world, which is still fails but is better)
… and done some cleaning
…er's" This reverts commit fb3ca18.
- fixed seeded generation - fixed broken logic when more than one SM world - added missing rules for inter-area transitions - added basic patch presence for logic - added DoorManager init call to reflect present patches for logic - moved CollectionState addition out of BaseClasses into SM world - added condition to apply progitempool presorting only if SM world is present - set Bosses item id to None to prevent them going into multidata - now use get_game_players
Co-authored-by: Exempt-Medic <[email protected]>
65 tasks
Exempt-Medic
approved these changes
Jun 4, 2024
Exempt-Medic
added
the
waiting-on: author
Exempt-Medic
removed
the
waiting-on: author
qwint
approved these changes
Jul 30, 2024
There was a problem hiding this comment.
format of the new options API looks good, did some searching and did not find any other uses of the old metadata.option_name[player] format
generated with default options and skip_output and confirmed there was no sm/smz3 warnings about Options API
did not test option combinations or fully patching and playing the relevant games
Exempt-Medic
added
waiting-on: core-review
|
This has conflicts btw @lordlou |
NewSoupVi
added
the
waiting-on: world-maintainer
Exempt-Medic
added
waiting-on: author
…_SMZ3_option_definitions_deprecation # Conflicts: # worlds/smz3/Options.py # worlds/smz3/__init__.py
Co-authored-by: Exempt-Medic <[email protected]>
Co-authored-by: Exempt-Medic <[email protected]>
Exempt-Medic
approved these changes
Aug 17, 2024
Exempt-Medic
removed
the
waiting-on: author
NewSoupVi
approved these changes
Aug 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Replaced deprecated use of option_definitions for SM and SMZ3 by options_dataclass
How was this tested?
Generated a multiworld with both game that succeeded without having warning message about deprecated use of option_definitions.