SMW: Option Groups and Presets #3345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
waiting-on: peer-review
Exempt-Medic
added
the
is: enhancement
Exempt-Medic
approved these changes
May 21, 2024
They're aesthetic in the sense that they don't have any impact on the logic or randomization at all. More how it's used in game design, as a separate categorization from "functionality" options. |
PoryGone
added
waiting-on: core-review
LegendaryLinux
approved these changes
May 21, 2024
Yes, I feel that option in particular should be a deliberate choice by the player. I can imagine people not expecting it to be randomized with everything else, and having a bad experience as a result |
jnschurig
pushed a commit
to Tranquilite0/Archipelago-SoulBlazer
that referenced
this pull request
Jun 13, 2024
* SMW: Add Option Groups and Presets * Fix Boss Shuffle Preset * Tooltip formatting
sflavelle
pushed a commit
to sflavelle/Archipelago-tgc
that referenced
this pull request
Jun 20, 2024
* SMW: Add Option Groups and Presets * Fix Boss Shuffle Preset * Tooltip formatting
qwint
pushed a commit
to qwint/Archipelago
that referenced
this pull request
Jun 24, 2024
* SMW: Add Option Groups and Presets * Fix Boss Shuffle Preset * Tooltip formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Option Groups and Presets for Super Mario World
How was this tested?
I ran the WebHost and see the Option Groups.
I verified the Presets set what I expect.
I generated template YAMLs from the launcher and saw the group headers.
If this makes graphical changes, please attach screenshots.