-
Notifications
You must be signed in to change notification settings - Fork 708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The Witness: Add some unit tests #3328
Conversation
import worlds.terraria??? lol one sec, I'll fix that |
…elago into some_unit_tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New tests == Good!
…FGJ'sklgösLGIKsdhJLGÖsdfjälghklDASFJghjladshfgjasdfälkjghasdöLfghasd-kjgjASDLÖGHAESKDLJGJÖsdaLGJHsadöKGjFDSLAkgjölSÄDghbASDFKGjasdLJGhjLÖSDGHLJASKDkgjldafjghjÖLADSFghäasdökgjäsadjlgkjsadkLHGsaDÖLGSADGÖLwSdlgkJLwDSFÄLHBJsaöfdkHweaFGIoeWjvlkdösmVJÄlsafdJKhvjdsJHFGLsdaövhWDsköLV-ksdFJHGVöSEKD
Co-authored-by: Exempt-Medic <[email protected]>
…elago into some_unit_tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comments and questions were addressed, the tests pass and make sense for the game. The changes in __init__.py
and options.py
make sense as well
Co-authored-by: black-sliver <[email protected]>
…elago into some_unit_tests
Why the sad face? :S In my mind the cut should happen where the code block stops making sense, becomes too large to follow easily or when you want a clean state/rely on modifying state (i.e. |
Idk if these make any sense but yeah
Also adds a hidden option allowing me (and people who know, I guess) to turn off the "put a random symbol on Tutorial Gate Open" thing