Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YGO06: make sure it runs on 3.8 support #3324

Merged
merged 2 commits into from
May 18, 2024

Conversation

Rensen3
Copy link
Contributor

@Rensen3 Rensen3 commented May 18, 2024

What is this fixing or adding?

Support Python 3.8

How was this tested?

The pipeline did run

@github-actions github-actions bot added the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label May 18, 2024
Copy link
Member

@black-sliver black-sliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I think merging the keys from multiple dicts into a list would be better than grabbing keys from merged dicts, the changed code should behave the same as before.

World loads on 3.8 now.

@black-sliver black-sliver merged commit 2bc3455 into ArchipelagoMW:main May 18, 2024
16 checks passed
jnschurig pushed a commit to Tranquilite0/Archipelago-SoulBlazer that referenced this pull request Jun 13, 2024
* YGO06: make sure it runs on python 3.8

* YGO06: change merge of dict, so it runs on python 3.8
sflavelle pushed a commit to sflavelle/Archipelago-tgc that referenced this pull request Jun 20, 2024
* YGO06: make sure it runs on python 3.8

* YGO06: change merge of dict, so it runs on python 3.8
qwint pushed a commit to qwint/Archipelago that referenced this pull request Jun 24, 2024
* YGO06: make sure it runs on python 3.8

* YGO06: change merge of dict, so it runs on python 3.8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting-on: peer-review Issue/PR has not been reviewed by enough people yet.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants