Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spelunker: Implement New Game #3282
base: main
Are you sure you want to change the base?
Spelunker: Implement New Game #3282
Changes from all commits
1ee9467
f14c704
cad67a8
1e6d15f
4a964e4
5f3608b
814b145
e45fd1c
39e056c
06faaa5
6b1358e
d4f61c2
4310e10
7c0a350
dee8fbb
0bccc74
6bbfeb2
95d70d6
cf3816c
b606513
ac0bd67
73a4b64
ceb36cf
ac3bcb5
c73df3d
005ebbf
2811813
176791d
c722172
fd4dd72
9a12623
0827165
6ddc992
29c8f8d
1169999
179e4cd
988193c
41f7c9c
5e7e8c2
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This means that two players playing on the same slot won't send deathlinks to each other. If you don't care about supporting that, don't worry about it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll have to think on this one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really don't know anything about clients, so this might be some issue somewhere outside of this world, but mypy does state:
I asked about it in the server https://discord.com/channels/731205301247803413/1214608557077700720/1275922312646103151
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is
location
used anywhere?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a time this can be
None
? If not, you can just do this:Another thing you could do is change the default to
0
and you could remove the, 0
from the item_table, but that's stylistic, and totally up to you