Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup: update cx_freeze to 7.x #3195

Merged
merged 2 commits into from
Apr 30, 2024

Conversation

black-sliver
Copy link
Member

What is this fixing or adding?

Make setup.py compatible to cx_freeze 7.x and upgrade cx_freeze.

How was this tested?

python setup.py build_exe bdist_appimage

Since this is a major release number change and was only tested very little, I'd strongly prefer to merge this after the upcoming release and merge #3194 now instead.

@github-actions github-actions bot added affects: core Issues/PRs that touch core and may need additional validation. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Apr 22, 2024
@Exempt-Medic Exempt-Medic added the is: maintenance Regular updates to requirements and utilities that do not fix bugs or change/add features. label Apr 26, 2024
Copy link
Member

@Berserker66 Berserker66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran it with Python 3.8 and 3.11 to Launcher.exe on windows 10. Looks to be working fine.

@black-sliver black-sliver merged commit 0ed0de3 into ArchipelagoMW:main Apr 30, 2024
12 checks passed
@black-sliver black-sliver deleted the update-cx_freeze branch April 30, 2024 23:48
jnschurig pushed a commit to Tranquilite0/Archipelago-SoulBlazer that referenced this pull request Jun 13, 2024
qwint pushed a commit to qwint/Archipelago that referenced this pull request Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects: core Issues/PRs that touch core and may need additional validation. is: maintenance Regular updates to requirements and utilities that do not fix bugs or change/add features. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants