Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CommonClient: handle Firefox removing the password part of userinfo #2773

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −0
Open

CommonClient: handle Firefox removing the password part of userinfo #2773

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CommonClient.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -612,6 +612,10 @@ async def server_loop(ctx: CommonContext, address: typing.Optional[str] = None)

address = f"ws://{address}" if "://" not in address \
else address.replace("archipelago://", "ws://")
uri = urllib.parse.urlparse(address)
if uri.username and uri.password is None:
# Fix for Firefox stripping empty password https://bugzilla.mozilla.org/show_bug.cgi?id=1876952
address = address.replace("@", ":@")

server_url = urllib.parse.urlparse(address)
if server_url.username:
Expand Down
Loading