CommonClient: Improve commands #2761
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
First one is a duplicate of #2675 |
ScipioWright
added
is: enhancement
ScipioWright
added
the
waiting-on: peer-review
EmilyV99
force-pushed
the
CommonClient
branch
5 times, most recently
from
b207af8 to
efc4e82
Compare
|
Did you test to make sure they still work without filter text? |
aye, they all work without filter text, and give a different message output (ex. |
beauxq
reviewed
Mar 5, 2024
beauxq
reviewed
Mar 7, 2024
beauxq
reviewed
Mar 7, 2024
beauxq
reviewed
Mar 23, 2024
Exempt-Medic
added
the
waiting-on: author
|
This has conflicts now just so you know |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Modified some basic CommonClient commands to be more useful.
'/missing' now properly can take multi-word filter text (instead of giving an error for invalid param count), and is case-insensitive.
'/received', '/items', and '/locations' now also take optional filter text.
Feedback from all changed commands also slightly improved (ex. now repeats the filter text used, indicating the results only include those that match that filter; where it previously showed a number of results, that now only counts those that match the filter, instead of all)
MultiServer's '!missing' and '!checked' have also received similar improvements.
How was this tested?
Ran all of the changed commands, checking for expected output. Some examples shown below.
Commands were tested both with and without filter text.
If this makes graphical changes, please attach screenshots.
(/received: Finding the days of the traveling cart in Stardew Valley that have been received was the main driving factor in this addition, and works flawlessly)
(!missing - the MultiServer command)
(!checked - the MultiServer command)
(/missing - the CommonClient command)
(/items)
(/locations)