Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lingo: Various item/location renames #2746

Merged
merged 14 commits into from
Feb 15, 2024
Merged

Lingo: Various item/location renames #2746

merged 14 commits into from
Feb 15, 2024

Conversation

hatkirby
Copy link
Collaborator

@hatkirby hatkirby commented Jan 21, 2024 •
edited
Loading

What is this fixing or adding?

  • Roof MASTERY panels are now technically in individual regions with more descriptive names, so they can be displayed better on the tracker.
  • Orange Tower Seventh Floor - Mastery has been renamed to simply Mastery.
  • The Optimistic is its own region now.
  • The misnamed CEILING in Room Room has been fixed.
  • The misnamed CHEESE in Challenge Room has been fixed.
  • The misnamed SOUND in Outside the Bold has been fixed.
  • "The Bearer - Shortcut to The Bold" is now "The Bearer - Entrance".
  • HUB ROOM - NEAR, FAR and the Warts Straw and Leaf Feel Areas have now been semantically combined into the "Symmetry Room". They are still logically three separate regions.
  • The FACTS chain in Challenge Room has been reindexed, and the full chain panel is now indicated as such.
  • The Room Room floors have been reindexed.
  • Panels in The Observant are now named by their questions, not answers.
  • Added a (1) subscript to several panels in Orange Tower Fourth Floor, Outside The Initiated, and The Seeker.

The validate_config.rb script has also been updated to check that all items and locations have an ID.

This change should not impact generation logic at all. It is just changing item and location names.

How was this tested?

validate_config.rb, pytest, and test generations.

If this makes graphical changes, please attach screenshots.

@hatkirby
Lingo: Various item/location renames
f0c4f56 
- Roof MASTERY panels are now technically in individual regions with more descriptive names, so they can be displayed better on the tracker.
- Orange Tower Seventh Floor - Mastery has been renamed to simply Mastery.
- The Optimistic is its own region now.
- The misnamed CEILING in Room Room has been fixed.
- The misnamed CHEESE in Challenge Room has been fixed.

The validate_config.rb script has also been updated to check that all items and locations have an ID.
@hatkirby
Merge remote-tracking branch 'upstream/main' into renames
e28e283
@hatkirby
Door_gray2 doesn't exist anymore
1178067
@hatkirby
Rename Bearer entrance
8c352e6
@hatkirby
Fix reference to old bearer entrance name
ccf4765
@hatkirby
Create Symmetry Room
bfa8436
@Jarno458 Jarno458 added the is: enhancement Issues requesting new features or pull requests implementing new features. label Jan 22, 2024
@hatkirby hatkirby marked this pull request as ready for review February 2, 2024 15:58
@PoryGone PoryGone added the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label Feb 10, 2024
@Exempt-Medic
Copy link
Member

Exempt-Medic commented Feb 12, 2024 •
edited
Loading

Figured it would be good to make a list of the panels I think could be renamed as well:

  • Challenge Room FACTS (0 1 3 4 5 6) → 123456
  • Room Room Floors (1 2 3 4 5 7 8 9) → 12345678
  • "Champion's Rest - EXIT" → "Champion's Rest - RED (1)"
    • "Champion's Rest - RED" → "Champion's Rest - Red (2)"
  • Everything in The Observant (other sets like PAINTING and PATH already use the prompt instead of the answer)
  • "The Undeterred - EYE" → "The Undeterred - EYE (1)"
  • "The Observant - HI" → "The Observant - HI (1)"
  • "Orange Tower Fourth Floor - RUNT" → "Orange Tower Fourth Floor - RUNT (1)"
  • "Outside The Initiated - PAST" → "Outside The Initiated - PAST (1)"
  • "Outside The Initiated - FUTURE" → "Outside The Initiated - FUTURE (1)"
  • "Rhyme Room (Target) - INNOVATIVE (Top/Bottom)" → "Rhyme Room (Target) - INNOVATIVE (1/2)"
  • "The Artistic (Panda) - EYE (Top/Bottom)" → "The Artistic (Panda) - EYE (1/2)"
  • "The Seeker - MINE" → "The Seeker - MINE (1)"
  • "The Seeker - BEAR" → "The Seeker - BEAR (1)"
  • "The Seeker - MOBILE" → "The Seeker - MOBILE (1)"

NewSoupVi
NewSoupVi approved these changes Feb 13, 2024
View reviewed changes
Copy link
Member

@NewSoupVi NewSoupVi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Walked around in-game to verify all the changes to location names & logic. Everything seems correct & sensible.

Did not review Ruby code. Didn't generate any seeds.

@ScipioWright ScipioWright added waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer. and removed waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Feb 14, 2024
@Berserker66 Berserker66 merged commit 2c38b9f into ArchipelagoMW:main Feb 15, 2024
15 checks passed
@github-actions github-actions bot removed the waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer. label Feb 15, 2024
Jouramie pushed a commit to Jouramie/Archipelago that referenced this pull request Feb 28, 2024
@hatkirby @Jouramie
Lingo: Various item/location renames (ArchipelagoMW#2746)
5750371 
## What is this fixing or adding?
- Roof MASTERY panels are now technically in individual regions with more descriptive names, so they can be displayed better on the tracker.
- Orange Tower Seventh Floor - Mastery has been renamed to simply Mastery.
- The Optimistic is its own region now.
- The misnamed CEILING in Room Room has been fixed.
- The misnamed CHEESE in Challenge Room has been fixed.
- The misnamed SOUND in Outside the Bold has been fixed.
- "The Bearer - Shortcut to The Bold" is now "The Bearer - Entrance".
- HUB ROOM - NEAR, FAR and the Warts Straw and Leaf Feel Areas have now been semantically combined into the "Symmetry Room". They are still logically three separate regions.
- The FACTS chain in Challenge Room has been reindexed, and the full chain panel is now indicated as such.
- The Room Room floors have been reindexed.
- Panels in The Observant are now named by their questions, not answers.
- Added a (1) subscript to several panels in Orange Tower Fourth Floor, Outside The Initiated, and The Seeker.

The validate_config.rb script has also been updated to check that all items and locations have an ID.

This change should not impact generation logic at all. It is just changing item and location names.
TheLX5 pushed a commit to TheLX5/Archipelago that referenced this pull request Mar 2, 2024
@hatkirby @TheLX5
Lingo: Various item/location renames (ArchipelagoMW#2746)
5d1c980 
## What is this fixing or adding?
- Roof MASTERY panels are now technically in individual regions with more descriptive names, so they can be displayed better on the tracker.
- Orange Tower Seventh Floor - Mastery has been renamed to simply Mastery.
- The Optimistic is its own region now.
- The misnamed CEILING in Room Room has been fixed.
- The misnamed CHEESE in Challenge Room has been fixed.
- The misnamed SOUND in Outside the Bold has been fixed.
- "The Bearer - Shortcut to The Bold" is now "The Bearer - Entrance".
- HUB ROOM - NEAR, FAR and the Warts Straw and Leaf Feel Areas have now been semantically combined into the "Symmetry Room". They are still logically three separate regions.
- The FACTS chain in Challenge Room has been reindexed, and the full chain panel is now indicated as such.
- The Room Room floors have been reindexed.
- Panels in The Observant are now named by their questions, not answers.
- Added a (1) subscript to several panels in Orange Tower Fourth Floor, Outside The Initiated, and The Seeker.

The validate_config.rb script has also been updated to check that all items and locations have an ID.

This change should not impact generation logic at all. It is just changing item and location names.
TheLX5 pushed a commit to TheLX5/Archipelago that referenced this pull request Mar 2, 2024
@hatkirby @TheLX5
Lingo: Various item/location renames (ArchipelagoMW#2746)
05669f1 
## What is this fixing or adding?
- Roof MASTERY panels are now technically in individual regions with more descriptive names, so they can be displayed better on the tracker.
- Orange Tower Seventh Floor - Mastery has been renamed to simply Mastery.
- The Optimistic is its own region now.
- The misnamed CEILING in Room Room has been fixed.
- The misnamed CHEESE in Challenge Room has been fixed.
- The misnamed SOUND in Outside the Bold has been fixed.
- "The Bearer - Shortcut to The Bold" is now "The Bearer - Entrance".
- HUB ROOM - NEAR, FAR and the Warts Straw and Leaf Feel Areas have now been semantically combined into the "Symmetry Room". They are still logically three separate regions.
- The FACTS chain in Challenge Room has been reindexed, and the full chain panel is now indicated as such.
- The Room Room floors have been reindexed.
- Panels in The Observant are now named by their questions, not answers.
- Added a (1) subscript to several panels in Orange Tower Fourth Floor, Outside The Initiated, and The Seeker.

The validate_config.rb script has also been updated to check that all items and locations have an ID.

This change should not impact generation logic at all. It is just changing item and location names.
EmilyV99 pushed a commit to EmilyV99/Archipelago that referenced this pull request Apr 15, 2024
@hatkirby @EmilyV99
Lingo: Various item/location renames (ArchipelagoMW#2746)
32d705e 
## What is this fixing or adding?
- Roof MASTERY panels are now technically in individual regions with more descriptive names, so they can be displayed better on the tracker.
- Orange Tower Seventh Floor - Mastery has been renamed to simply Mastery.
- The Optimistic is its own region now.
- The misnamed CEILING in Room Room has been fixed.
- The misnamed CHEESE in Challenge Room has been fixed.
- The misnamed SOUND in Outside the Bold has been fixed.
- "The Bearer - Shortcut to The Bold" is now "The Bearer - Entrance".
- HUB ROOM - NEAR, FAR and the Warts Straw and Leaf Feel Areas have now been semantically combined into the "Symmetry Room". They are still logically three separate regions.
- The FACTS chain in Challenge Room has been reindexed, and the full chain panel is now indicated as such.
- The Room Room floors have been reindexed.
- Panels in The Observant are now named by their questions, not answers.
- Added a (1) subscript to several panels in Orange Tower Fourth Floor, Outside The Initiated, and The Seeker.

The validate_config.rb script has also been updated to check that all items and locations have an ID.

This change should not impact generation logic at all. It is just changing item and location names.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NewSoupVi NewSoupVi NewSoupVi approved these changes

@Berserker66 Berserker66 Berserker66 approved these changes

Assignees
No one assigned
Labels
is: enhancement Issues requesting new features or pull requests implementing new features.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@hatkirby @Exempt-Medic @Berserker66 @NewSoupVi @Jarno458 @ScipioWright @PoryGone