KH2: Version 3 #2733
Draft
KH2: Version 3 #2733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To me, this looks like it does quite a lot more than just add puzzle piece locations. I feel like this could be split apart into quite a few different PRs. One for the deathlink chages, one for all the reformatting, one for the puzzle pieces, and maybe even one for the client changes. Edit/Update: PR title was changed, it seems fine now that this does a lot at once |
cleaned up form rules to be not disgusting
KH2: Rename puzzle pieces to be more consistent with other checks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please format your title with what portion of the project this pull request is
targeting and what it's changing.
ex. "MyGame4: implement new game" or "Docs: add new guide for customizing MyGame3"
What is this fixing or adding?
adds puzzle pieces as locations
cleans up some patch making/clarifying magic numbers
How was this tested?
unitttests and making sure the locations send
If this makes graphical changes, please attach screenshots.