Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Super Mario land 2: implement new game #2730

Open
wants to merge 135 commits into
base: main
Choose a base branch
from

Conversation

Alchav
Copy link
Contributor

@Alchav Alchav commented Jan 16, 2024

What is this fixing or adding?

Adds Super Mario Land 2 to Archipelago

  • Completing levels (normal and secret exits) results in checks.
  • Progression from level to level is unlocked by items.
  • The ability to use powerups, enjoy proper space or water physics, enter hippo bubbles, and, optionally, enter pipes, are shuffled as items.
  • Optionally, midway point bells can be shuffled, so that the bells in the levels result in location checks, and bell items to let you skip to the midway point are in the item pool.
  • Optionally, coins can be shuffled so that coins or coin bundles are placed in the item pool and checks are made by reaching thresholds of coins collected within a single run of a level.

How was this tested?

Many playthroughs by myself, my siblings, and various users with the apworld distributed in #future-game-design.

Special thanks

@froggestspirit - SML2R disassembly which, while very incomplete, had enough memory values mapped out to give me a large head start on this project.
@slashinfty - permitting me to copy features such as Randomize Enemies and Randomize Platforms directly from https://github.com/slashinfty/sml2r-node

@ScipioWright ScipioWright added the is: new game Pull requests for implementing new games into Archipelago. label Jan 16, 2024
Copy link
Contributor

@nicholassaylor nicholassaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Player settings -> Player options because of the conventions change recently

worlds/marioland2/docs/en_Super Mario Land 2.md Outdated Show resolved Hide resolved
worlds/marioland2/docs/setup_en.md Outdated Show resolved Hide resolved
worlds/marioland2/docs/setup_en.md Outdated Show resolved Hide resolved
@Exempt-Medic
Copy link
Member

Exempt-Medic commented Sep 10, 2024

Using this "yaml": weights.json
Grabbed directly from your repo and merged into something close to main then did 50 single-world generations.
19 of these 50 failed generation.

Seed: 3140977367115741983

Exception: Could not access required locations for accessibility check. Missing: [Mario Zone 3 - 33 Coins, Mario Zone 3 - 41 Coins, Mario Zone 3 - 30 Coins, Mario Zone 3 - 42 Coins, Mario Zone 3 - 34 Coins, Mario Zone 3 - 45 Coins, Mario Zone 3 - 44 Coins, Mario Zone 3 - 36 Coins, Mario Zone 3 - 46 Coins, Mario Zone 3 - 47 Coins, Mario Zone 3 - 32 Coins, Mario Zone 3 - 39 Coins, Mario Zone 3 - 38 Coins, Mario Zone 3 - 31 Coins, Mario Zone 3 - 43 Coins, Mario Zone 3 - 40 Coins, Mario Zone 3 - 35 Coins, Mario Zone 3 - 37 Coins]

Seed: 74452366905380076756

Exception: Could not access required locations for accessibility check. Missing: [Mario Zone 3 - 43 Coins, Mario Zone 3 - 37 Coins, Mario Zone 3 - 41 Coins, Mario Zone 3 - 47 Coins, Mario Zone 3 - 33 Coins, Mario Zone 3 - 38 Coins, Mario Zone 3 - 40 Coins, Mario Zone 3 - 45 Coins, Mario Zone 3 - 36 Coins, Mario Zone 3 - 44 Coins, Mario Zone 3 - 31 Coins, Mario Zone 3 - 42 Coins, Mario Zone 3 - 30 Coins, Mario Zone 3 - 34 Coins, Mario Zone 3 - 39 Coins, Mario Zone 3 - 35 Coins, Mario Zone 3 - 32 Coins, Mario Zone 3 - 46 Coins]

Seed: 67525056881403369433

Exception: Could not access required locations for accessibility check. Missing: [Mario Zone 3 - 42 Coins, Mario Zone 3 - 37 Coins, Mario Zone 3 - 40 Coins, Mario Zone 3 - 45 Coins, Mario Zone 3 - 36 Coins, Mario Zone 3 - 39 Coins, Mario Zone 3 - 30 Coins, Mario Zone 3 - 32 Coins, Mario Zone 3 - 31 Coins, Mario Zone 3 - 35 Coins, Mario Zone 3 - 33 Coins, Mario Zone 3 - 43 Coins, Mario Zone 3 - 46 Coins, Mario Zone 3 - 38 Coins, Mario Zone 3 - 34 Coins, Mario Zone 3 - 44 Coins, Mario Zone 3 - 41 Coins, Mario Zone 3 - 47 Coins]

Seed: 79973590260123359534

Exception: Could not access required locations for accessibility check. Missing: [Mario Zone 3 - 36 Coins, Mario Zone 3 - 38 Coins, Mario Zone 3 - 31 Coins, Mario Zone 3 - 33 Coins, Mario Zone 3 - 35 Coins, Mario Zone 3 - 39 Coins, Mario Zone 3 - 40 Coins, Mario Zone 3 - 44 Coins, Mario Zone 3 - 34 Coins, Mario Zone 3 - 42 Coins, Mario Zone 3 - 41 Coins, Mario Zone 3 - 45 Coins, Mario Zone 3 - 47 Coins, Mario Zone 3 - 37 Coins, Mario Zone 3 - 32 Coins, Mario Zone 3 - 43 Coins, Mario Zone 3 - 46 Coins, Mario Zone 3 - 30 Coins]

Seed: 50122027873440332214

Exception: Could not access required locations for accessibility check. Missing: [Pumpkin Zone 1 - Normal Exit, Pumpkin Zone 1 - 9 Coins, Pumpkin Zone 1 - 6 Coins, Pumpkin Zone 1 - 10 Coins, Pumpkin Zone 1 - 11 Coins, Pumpkin Zone 1 - 5 Coins, Pumpkin Zone 1 - 12 Coins, Pumpkin Zone 1 - 4 Coins, Pumpkin Zone 1 - 1 Coin, Pumpkin Zone 1 - 2 Coins, Pumpkin Zone 1 - 8 Coins, Pumpkin Zone 1 - 3 Coins, Pumpkin Zone 1 - 7 Coins]

Seed: 20074709390181434850

Exception: Could not access required locations for accessibility check. Missing: [Pumpkin Zone 1 - Normal Exit, Pumpkin Zone 1 - 7 Coins, Pumpkin Zone 1 - 9 Coins, Pumpkin Zone 1 - 10 Coins, Pumpkin Zone 1 - 11 Coins, Pumpkin Zone 1 - 6 Coins, Pumpkin Zone 1 - 12 Coins, Pumpkin Zone 1 - 5 Coins, Pumpkin Zone 1 - 2 Coins, Pumpkin Zone 1 - 8 Coins, Pumpkin Zone 1 - 4 Coins, Pumpkin Zone 1 - 3 Coins, Pumpkin Zone 1 - 1 Coin, Mario Zone 3 - 30 Coins, Mario Zone 3 - 35 Coins, Mario Zone 3 - 40 Coins, Mario Zone 3 - 45 Coins, Mario Zone 3 - 34 Coins, Mario Zone 3 - 33 Coins, Mario Zone 3 - 47 Coins, Mario Zone 3 - 32 Coins, Mario Zone 3 - 46 Coins, Mario Zone 3 - 37 Coins, Mario Zone 3 - 41 Coins, Mario Zone 3 - 36 Coins, Mario Zone 3 - 38 Coins, Mario Zone 3 - 44 Coins, Mario Zone 3 - 43 Coins, Mario Zone 3 - 42 Coins, Mario Zone 3 - 39 Coins, Mario Zone 3 - 31 Coins]

Seed: 72121756904878922930

Exception: Could not access required locations for accessibility check. Missing: [Mario Zone 3 - 40 Coins, Mario Zone 3 - 35 Coins, Mario Zone 3 - 41 Coins, Mario Zone 3 - 44 Coins, Mario Zone 3 - 47 Coins, Mario Zone 3 - 39 Coins, Mario Zone 3 - 45 Coins, Mario Zone 3 - 32 Coins, Mario Zone 3 - 34 Coins, Mario Zone 3 - 43 Coins, Mario Zone 3 - 37 Coins, Mario Zone 3 - 46 Coins, Mario Zone 3 - 33 Coins, Mario Zone 3 - 38 Coins, Mario Zone 3 - 30 Coins, Mario Zone 3 - 42 Coins, Mario Zone 3 - 31 Coins, Mario Zone 3 - 36 Coins]

Seed: 32555925167180822741

Exception: Could not access required locations for accessibility check. Missing: [Mario Zone 3 - 38 Coins, Mario Zone 3 - 47 Coins, Mario Zone 3 - 30 Coins, Mario Zone 3 - 35 Coins, Mario Zone 3 - 43 Coins, Mario Zone 3 - 46 Coins, Mario Zone 3 - 45 Coins, Mario Zone 3 - 40 Coins, Mario Zone 3 - 42 Coins, Mario Zone 3 - 32 Coins, Mario Zone 3 - 41 Coins, Mario Zone 3 - 44 Coins, Mario Zone 3 - 37 Coins, Mario Zone 3 - 39 Coins, Mario Zone 3 - 31 Coins, Mario Zone 3 - 36 Coins, Mario Zone 3 - 34 Coins, Mario Zone 3 - 33 Coins]

Seed: 89630613769312299416

Exception: Could not access required locations for accessibility check. Missing: [Pumpkin Zone 1 - Normal Exit, Pumpkin Zone 1 - 9 Coins, Pumpkin Zone 1 - 12 Coins, Pumpkin Zone 1 - 2 Coins, Pumpkin Zone 1 - 6 Coins, Pumpkin Zone 1 - 11 Coins, Pumpkin Zone 1 - 10 Coins, Pumpkin Zone 1 - 1 Coin, Pumpkin Zone 1 - 5 Coins, Pumpkin Zone 1 - 7 Coins, Pumpkin Zone 1 - 4 Coins, Pumpkin Zone 1 - 3 Coins, Pumpkin Zone 1 - 8 Coins, Mario Zone 3 - 47 Coins, Mario Zone 3 - 41 Coins, Mario Zone 3 - 45 Coins, Mario Zone 3 - 31 Coins, Mario Zone 3 - 38 Coins, Mario Zone 3 - 42 Coins, Mario Zone 3 - 46 Coins, Mario Zone 3 - 34 Coins, Mario Zone 3 - 43 Coins, Mario Zone 3 - 37 Coins, Mario Zone 3 - 30 Coins, Mario Zone 3 - 32 Coins, Mario Zone 3 - 35 Coins, Mario Zone 3 - 33 Coins, Mario Zone 3 - 44 Coins, Mario Zone 3 - 36 Coins, Mario Zone 3 - 39 Coins, Mario Zone 3 - 40 Coins]

Seed: 2080379675966903169

Exception: Could not access required locations for accessibility check. Missing: [Mario Zone 3 - 40 Coins, Mario Zone 3 - 38 Coins, Mario Zone 3 - 42 Coins, Mario Zone 3 - 35 Coins, Mario Zone 3 - 44 Coins, Mario Zone 3 - 33 Coins, Mario Zone 3 - 43 Coins, Mario Zone 3 - 46 Coins, Mario Zone 3 - 36 Coins, Mario Zone 3 - 47 Coins, Mario Zone 3 - 34 Coins, Mario Zone 3 - 37 Coins, Mario Zone 3 - 30 Coins, Mario Zone 3 - 31 Coins, Mario Zone 3 - 41 Coins, Mario Zone 3 - 32 Coins, Mario Zone 3 - 45 Coins, Mario Zone 3 - 39 Coins]

Seed: 34558351285475557998

Exception: Could not access required locations for accessibility check. Missing: [Pumpkin Zone 1 - Normal Exit, Pumpkin Zone 1 - 6 Coins, Pumpkin Zone 1 - 4 Coins, Pumpkin Zone 1 - 9 Coins, Pumpkin Zone 1 - 10 Coins, Pumpkin Zone 1 - 11 Coins, Pumpkin Zone 1 - 2 Coins, Pumpkin Zone 1 - 7 Coins, Pumpkin Zone 1 - 12 Coins, Pumpkin Zone 1 - 5 Coins, Pumpkin Zone 1 - 8 Coins, Pumpkin Zone 1 - 3 Coins, Pumpkin Zone 1 - 1 Coin, Mario Zone 3 - 42 Coins, Mario Zone 3 - 36 Coins, Mario Zone 3 - 43 Coins, Mario Zone 3 - 34 Coins, Mario Zone 3 - 31 Coins, Mario Zone 3 - 40 Coins, Mario Zone 3 - 41 Coins, Mario Zone 3 - 39 Coins, Mario Zone 3 - 45 Coins, Mario Zone 3 - 38 Coins, Mario Zone 3 - 44 Coins, Mario Zone 3 - 47 Coins, Mario Zone 3 - 30 Coins, Mario Zone 3 - 32 Coins, Mario Zone 3 - 35 Coins, Mario Zone 3 - 37 Coins, Mario Zone 3 - 33 Coins, Mario Zone 3 - 46 Coins]

Seed: 39104142746715063486

Exception: Could not access required locations for accessibility check. Missing: [Pumpkin Zone 1 - Normal Exit, Pumpkin Zone 1 - 4 Coins, Pumpkin Zone 1 - 6 Coins, Pumpkin Zone 1 - 5 Coins, Pumpkin Zone 1 - 8 Coins, Pumpkin Zone 1 - 3 Coins, Pumpkin Zone 1 - 2 Coins, Pumpkin Zone 1 - 1 Coin, Pumpkin Zone 1 - 11 Coins, Pumpkin Zone 1 - 9 Coins, Pumpkin Zone 1 - 10 Coins, Pumpkin Zone 1 - 7 Coins, Pumpkin Zone 1 - 12 Coins]

Seed: 39305674031749663756

Exception: Could not access required locations for accessibility check. Missing: [Pumpkin Zone 1 - Normal Exit, Pumpkin Zone 1 - 2 Coins, Pumpkin Zone 1 - 6 Coins, Pumpkin Zone 1 - 11 Coins, Pumpkin Zone 1 - 3 Coins, Pumpkin Zone 1 - 9 Coins, Pumpkin Zone 1 - 10 Coins, Pumpkin Zone 1 - 1 Coin, Pumpkin Zone 1 - 12 Coins, Pumpkin Zone 1 - 5 Coins, Pumpkin Zone 1 - 7 Coins, Pumpkin Zone 1 - 4 Coins, Pumpkin Zone 1 - 8 Coins]

Seed: 87889259907772389146

Exception: Could not access required locations for accessibility check. Missing: [Mario Zone 3 - 33 Coins, Mario Zone 3 - 47 Coins, Mario Zone 3 - 38 Coins, Mario Zone 3 - 41 Coins, Mario Zone 3 - 39 Coins, Mario Zone 3 - 37 Coins, Mario Zone 3 - 40 Coins, Mario Zone 3 - 30 Coins, Mario Zone 3 - 31 Coins, Mario Zone 3 - 32 Coins, Mario Zone 3 - 36 Coins, Mario Zone 3 - 35 Coins, Mario Zone 3 - 44 Coins, Mario Zone 3 - 43 Coins, Mario Zone 3 - 46 Coins, Mario Zone 3 - 34 Coins, Mario Zone 3 - 42 Coins, Mario Zone 3 - 45 Coins]

Seed: 54861075578340091194

Exception: Could not access required locations for accessibility check. Missing: [Mario Zone 3 - 33 Coins, Mario Zone 3 - 42 Coins, Mario Zone 3 - 40 Coins, Mario Zone 3 - 41 Coins, Mario Zone 3 - 47 Coins, Mario Zone 3 - 37 Coins, Mario Zone 3 - 32 Coins, Mario Zone 3 - 31 Coins, Mario Zone 3 - 45 Coins, Mario Zone 3 - 38 Coins, Mario Zone 3 - 34 Coins, Mario Zone 3 - 35 Coins, Mario Zone 3 - 43 Coins, Mario Zone 3 - 30 Coins, Mario Zone 3 - 44 Coins, Mario Zone 3 - 46 Coins, Mario Zone 3 - 36 Coins, Mario Zone 3 - 39 Coins]

Seed: 19246233477726224197

Exception: Could not access required locations for accessibility check. Missing: [Mario Zone 3 - 31 Coins, Mario Zone 3 - 44 Coins, Mario Zone 3 - 45 Coins, Mario Zone 3 - 37 Coins, Mario Zone 3 - 39 Coins, Mario Zone 3 - 46 Coins, Mario Zone 3 - 40 Coins, Mario Zone 3 - 43 Coins, Mario Zone 3 - 36 Coins, Mario Zone 3 - 35 Coins, Mario Zone 3 - 32 Coins, Mario Zone 3 - 34 Coins, Mario Zone 3 - 47 Coins, Mario Zone 3 - 38 Coins, Mario Zone 3 - 33 Coins, Mario Zone 3 - 41 Coins, Mario Zone 3 - 30 Coins, Mario Zone 3 - 42 Coins]

Seed: 55051236482054671527

Exception: Could not access required locations for accessibility check. Missing: [Mario Zone 3 - 34 Coins, Mario Zone 3 - 45 Coins, Mario Zone 3 - 36 Coins, Mario Zone 3 - 46 Coins, Mario Zone 3 - 44 Coins, Mario Zone 3 - 38 Coins, Mario Zone 3 - 42 Coins, Mario Zone 3 - 40 Coins, Mario Zone 3 - 35 Coins, Mario Zone 3 - 30 Coins, Mario Zone 3 - 39 Coins, Mario Zone 3 - 33 Coins, Mario Zone 3 - 47 Coins, Mario Zone 3 - 43 Coins, Mario Zone 3 - 37 Coins, Mario Zone 3 - 41 Coins, Mario Zone 3 - 31 Coins, Mario Zone 3 - 32 Coins]

Seed: 50671643921938774021

Exception: Could not access required locations for accessibility check. Missing: [Mario Zone 3 - 42 Coins, Mario Zone 3 - 32 Coins, Mario Zone 3 - 34 Coins, Mario Zone 3 - 44 Coins, Mario Zone 3 - 46 Coins, Mario Zone 3 - 33 Coins, Mario Zone 3 - 40 Coins, Mario Zone 3 - 31 Coins, Mario Zone 3 - 35 Coins, Mario Zone 3 - 41 Coins, Mario Zone 3 - 38 Coins, Mario Zone 3 - 47 Coins, Mario Zone 3 - 37 Coins, Mario Zone 3 - 43 Coins, Mario Zone 3 - 36 Coins, Mario Zone 3 - 30 Coins, Mario Zone 3 - 39 Coins, Mario Zone 3 - 45 Coins]

Seed: 78301089125151606985

Exception: Could not access required locations for accessibility check. Missing: [Mario Zone 3 - 32 Coins, Mario Zone 3 - 40 Coins, Mario Zone 3 - 37 Coins, Mario Zone 3 - 38 Coins, Mario Zone 3 - 46 Coins, Mario Zone 3 - 43 Coins, Mario Zone 3 - 47 Coins, Mario Zone 3 - 36 Coins, Mario Zone 3 - 39 Coins, Mario Zone 3 - 34 Coins, Mario Zone 3 - 31 Coins, Mario Zone 3 - 35 Coins, Mario Zone 3 - 44 Coins, Mario Zone 3 - 42 Coins, Mario Zone 3 - 41 Coins, Mario Zone 3 - 45 Coins, Mario Zone 3 - 33 Coins, Mario Zone 3 - 30 Coins]

@Alchav
Copy link
Contributor Author

Alchav commented Sep 10, 2024

Using this "yaml": weights.json Grabbed directly from your repo and merged into something close to main then did 50 single-world generations. 19 of these 50 failed generation.

Seed: 3140977367115741983

Exception: Could not access required locations for accessibility check. Missing: [Mario Zone 3 - 33 Coins, Mario Zone 3 - 41 Coins, Mario Zone 3 - 30 Coins, Mario Zone 3 - 42 Coins, Mario Zone 3 - 34 Coins, Mario Zone 3 - 45 Coins, Mario Zone 3 - 44 Coins, Mario Zone 3 - 36 Coins, Mario Zone 3 - 46 Coins, Mario Zone 3 - 47 Coins, Mario Zone 3 - 32 Coins, Mario Zone 3 - 39 Coins, Mario Zone 3 - 38 Coins, Mario Zone 3 - 31 Coins, Mario Zone 3 - 43 Coins, Mario Zone 3 - 40 Coins, Mario Zone 3 - 35 Coins, Mario Zone 3 - 37 Coins]

Seed: 74452366905380076756

Exception: Could not access required locations for accessibility check. Missing: [Mario Zone 3 - 43 Coins, Mario Zone 3 - 37 Coins, Mario Zone 3 - 41 Coins, Mario Zone 3 - 47 Coins, Mario Zone 3 - 33 Coins, Mario Zone 3 - 38 Coins, Mario Zone 3 - 40 Coins, Mario Zone 3 - 45 Coins, Mario Zone 3 - 36 Coins, Mario Zone 3 - 44 Coins, Mario Zone 3 - 31 Coins, Mario Zone 3 - 42 Coins, Mario Zone 3 - 30 Coins, Mario Zone 3 - 34 Coins, Mario Zone 3 - 39 Coins, Mario Zone 3 - 35 Coins, Mario Zone 3 - 32 Coins, Mario Zone 3 - 46 Coins]

Seed: 67525056881403369433

Exception: Could not access required locations for accessibility check. Missing: [Mario Zone 3 - 42 Coins, Mario Zone 3 - 37 Coins, Mario Zone 3 - 40 Coins, Mario Zone 3 - 45 Coins, Mario Zone 3 - 36 Coins, Mario Zone 3 - 39 Coins, Mario Zone 3 - 30 Coins, Mario Zone 3 - 32 Coins, Mario Zone 3 - 31 Coins, Mario Zone 3 - 35 Coins, Mario Zone 3 - 33 Coins, Mario Zone 3 - 43 Coins, Mario Zone 3 - 46 Coins, Mario Zone 3 - 38 Coins, Mario Zone 3 - 34 Coins, Mario Zone 3 - 44 Coins, Mario Zone 3 - 41 Coins, Mario Zone 3 - 47 Coins]

Seed: 79973590260123359534

Exception: Could not access required locations for accessibility check. Missing: [Mario Zone 3 - 36 Coins, Mario Zone 3 - 38 Coins, Mario Zone 3 - 31 Coins, Mario Zone 3 - 33 Coins, Mario Zone 3 - 35 Coins, Mario Zone 3 - 39 Coins, Mario Zone 3 - 40 Coins, Mario Zone 3 - 44 Coins, Mario Zone 3 - 34 Coins, Mario Zone 3 - 42 Coins, Mario Zone 3 - 41 Coins, Mario Zone 3 - 45 Coins, Mario Zone 3 - 47 Coins, Mario Zone 3 - 37 Coins, Mario Zone 3 - 32 Coins, Mario Zone 3 - 43 Coins, Mario Zone 3 - 46 Coins, Mario Zone 3 - 30 Coins]

Seed: 50122027873440332214

Exception: Could not access required locations for accessibility check. Missing: [Pumpkin Zone 1 - Normal Exit, Pumpkin Zone 1 - 9 Coins, Pumpkin Zone 1 - 6 Coins, Pumpkin Zone 1 - 10 Coins, Pumpkin Zone 1 - 11 Coins, Pumpkin Zone 1 - 5 Coins, Pumpkin Zone 1 - 12 Coins, Pumpkin Zone 1 - 4 Coins, Pumpkin Zone 1 - 1 Coin, Pumpkin Zone 1 - 2 Coins, Pumpkin Zone 1 - 8 Coins, Pumpkin Zone 1 - 3 Coins, Pumpkin Zone 1 - 7 Coins]

Seed: 20074709390181434850

Exception: Could not access required locations for accessibility check. Missing: [Pumpkin Zone 1 - Normal Exit, Pumpkin Zone 1 - 7 Coins, Pumpkin Zone 1 - 9 Coins, Pumpkin Zone 1 - 10 Coins, Pumpkin Zone 1 - 11 Coins, Pumpkin Zone 1 - 6 Coins, Pumpkin Zone 1 - 12 Coins, Pumpkin Zone 1 - 5 Coins, Pumpkin Zone 1 - 2 Coins, Pumpkin Zone 1 - 8 Coins, Pumpkin Zone 1 - 4 Coins, Pumpkin Zone 1 - 3 Coins, Pumpkin Zone 1 - 1 Coin, Mario Zone 3 - 30 Coins, Mario Zone 3 - 35 Coins, Mario Zone 3 - 40 Coins, Mario Zone 3 - 45 Coins, Mario Zone 3 - 34 Coins, Mario Zone 3 - 33 Coins, Mario Zone 3 - 47 Coins, Mario Zone 3 - 32 Coins, Mario Zone 3 - 46 Coins, Mario Zone 3 - 37 Coins, Mario Zone 3 - 41 Coins, Mario Zone 3 - 36 Coins, Mario Zone 3 - 38 Coins, Mario Zone 3 - 44 Coins, Mario Zone 3 - 43 Coins, Mario Zone 3 - 42 Coins, Mario Zone 3 - 39 Coins, Mario Zone 3 - 31 Coins]

Seed: 72121756904878922930

Exception: Could not access required locations for accessibility check. Missing: [Mario Zone 3 - 40 Coins, Mario Zone 3 - 35 Coins, Mario Zone 3 - 41 Coins, Mario Zone 3 - 44 Coins, Mario Zone 3 - 47 Coins, Mario Zone 3 - 39 Coins, Mario Zone 3 - 45 Coins, Mario Zone 3 - 32 Coins, Mario Zone 3 - 34 Coins, Mario Zone 3 - 43 Coins, Mario Zone 3 - 37 Coins, Mario Zone 3 - 46 Coins, Mario Zone 3 - 33 Coins, Mario Zone 3 - 38 Coins, Mario Zone 3 - 30 Coins, Mario Zone 3 - 42 Coins, Mario Zone 3 - 31 Coins, Mario Zone 3 - 36 Coins]

Seed: 32555925167180822741

Exception: Could not access required locations for accessibility check. Missing: [Mario Zone 3 - 38 Coins, Mario Zone 3 - 47 Coins, Mario Zone 3 - 30 Coins, Mario Zone 3 - 35 Coins, Mario Zone 3 - 43 Coins, Mario Zone 3 - 46 Coins, Mario Zone 3 - 45 Coins, Mario Zone 3 - 40 Coins, Mario Zone 3 - 42 Coins, Mario Zone 3 - 32 Coins, Mario Zone 3 - 41 Coins, Mario Zone 3 - 44 Coins, Mario Zone 3 - 37 Coins, Mario Zone 3 - 39 Coins, Mario Zone 3 - 31 Coins, Mario Zone 3 - 36 Coins, Mario Zone 3 - 34 Coins, Mario Zone 3 - 33 Coins]

Seed: 89630613769312299416

Exception: Could not access required locations for accessibility check. Missing: [Pumpkin Zone 1 - Normal Exit, Pumpkin Zone 1 - 9 Coins, Pumpkin Zone 1 - 12 Coins, Pumpkin Zone 1 - 2 Coins, Pumpkin Zone 1 - 6 Coins, Pumpkin Zone 1 - 11 Coins, Pumpkin Zone 1 - 10 Coins, Pumpkin Zone 1 - 1 Coin, Pumpkin Zone 1 - 5 Coins, Pumpkin Zone 1 - 7 Coins, Pumpkin Zone 1 - 4 Coins, Pumpkin Zone 1 - 3 Coins, Pumpkin Zone 1 - 8 Coins, Mario Zone 3 - 47 Coins, Mario Zone 3 - 41 Coins, Mario Zone 3 - 45 Coins, Mario Zone 3 - 31 Coins, Mario Zone 3 - 38 Coins, Mario Zone 3 - 42 Coins, Mario Zone 3 - 46 Coins, Mario Zone 3 - 34 Coins, Mario Zone 3 - 43 Coins, Mario Zone 3 - 37 Coins, Mario Zone 3 - 30 Coins, Mario Zone 3 - 32 Coins, Mario Zone 3 - 35 Coins, Mario Zone 3 - 33 Coins, Mario Zone 3 - 44 Coins, Mario Zone 3 - 36 Coins, Mario Zone 3 - 39 Coins, Mario Zone 3 - 40 Coins]

Seed: 2080379675966903169

Exception: Could not access required locations for accessibility check. Missing: [Mario Zone 3 - 40 Coins, Mario Zone 3 - 38 Coins, Mario Zone 3 - 42 Coins, Mario Zone 3 - 35 Coins, Mario Zone 3 - 44 Coins, Mario Zone 3 - 33 Coins, Mario Zone 3 - 43 Coins, Mario Zone 3 - 46 Coins, Mario Zone 3 - 36 Coins, Mario Zone 3 - 47 Coins, Mario Zone 3 - 34 Coins, Mario Zone 3 - 37 Coins, Mario Zone 3 - 30 Coins, Mario Zone 3 - 31 Coins, Mario Zone 3 - 41 Coins, Mario Zone 3 - 32 Coins, Mario Zone 3 - 45 Coins, Mario Zone 3 - 39 Coins]

Seed: 34558351285475557998

Exception: Could not access required locations for accessibility check. Missing: [Pumpkin Zone 1 - Normal Exit, Pumpkin Zone 1 - 6 Coins, Pumpkin Zone 1 - 4 Coins, Pumpkin Zone 1 - 9 Coins, Pumpkin Zone 1 - 10 Coins, Pumpkin Zone 1 - 11 Coins, Pumpkin Zone 1 - 2 Coins, Pumpkin Zone 1 - 7 Coins, Pumpkin Zone 1 - 12 Coins, Pumpkin Zone 1 - 5 Coins, Pumpkin Zone 1 - 8 Coins, Pumpkin Zone 1 - 3 Coins, Pumpkin Zone 1 - 1 Coin, Mario Zone 3 - 42 Coins, Mario Zone 3 - 36 Coins, Mario Zone 3 - 43 Coins, Mario Zone 3 - 34 Coins, Mario Zone 3 - 31 Coins, Mario Zone 3 - 40 Coins, Mario Zone 3 - 41 Coins, Mario Zone 3 - 39 Coins, Mario Zone 3 - 45 Coins, Mario Zone 3 - 38 Coins, Mario Zone 3 - 44 Coins, Mario Zone 3 - 47 Coins, Mario Zone 3 - 30 Coins, Mario Zone 3 - 32 Coins, Mario Zone 3 - 35 Coins, Mario Zone 3 - 37 Coins, Mario Zone 3 - 33 Coins, Mario Zone 3 - 46 Coins]

Seed: 39104142746715063486

Exception: Could not access required locations for accessibility check. Missing: [Pumpkin Zone 1 - Normal Exit, Pumpkin Zone 1 - 4 Coins, Pumpkin Zone 1 - 6 Coins, Pumpkin Zone 1 - 5 Coins, Pumpkin Zone 1 - 8 Coins, Pumpkin Zone 1 - 3 Coins, Pumpkin Zone 1 - 2 Coins, Pumpkin Zone 1 - 1 Coin, Pumpkin Zone 1 - 11 Coins, Pumpkin Zone 1 - 9 Coins, Pumpkin Zone 1 - 10 Coins, Pumpkin Zone 1 - 7 Coins, Pumpkin Zone 1 - 12 Coins]

Seed: 39305674031749663756

Exception: Could not access required locations for accessibility check. Missing: [Pumpkin Zone 1 - Normal Exit, Pumpkin Zone 1 - 2 Coins, Pumpkin Zone 1 - 6 Coins, Pumpkin Zone 1 - 11 Coins, Pumpkin Zone 1 - 3 Coins, Pumpkin Zone 1 - 9 Coins, Pumpkin Zone 1 - 10 Coins, Pumpkin Zone 1 - 1 Coin, Pumpkin Zone 1 - 12 Coins, Pumpkin Zone 1 - 5 Coins, Pumpkin Zone 1 - 7 Coins, Pumpkin Zone 1 - 4 Coins, Pumpkin Zone 1 - 8 Coins]

Seed: 87889259907772389146

Exception: Could not access required locations for accessibility check. Missing: [Mario Zone 3 - 33 Coins, Mario Zone 3 - 47 Coins, Mario Zone 3 - 38 Coins, Mario Zone 3 - 41 Coins, Mario Zone 3 - 39 Coins, Mario Zone 3 - 37 Coins, Mario Zone 3 - 40 Coins, Mario Zone 3 - 30 Coins, Mario Zone 3 - 31 Coins, Mario Zone 3 - 32 Coins, Mario Zone 3 - 36 Coins, Mario Zone 3 - 35 Coins, Mario Zone 3 - 44 Coins, Mario Zone 3 - 43 Coins, Mario Zone 3 - 46 Coins, Mario Zone 3 - 34 Coins, Mario Zone 3 - 42 Coins, Mario Zone 3 - 45 Coins]

Seed: 54861075578340091194

Exception: Could not access required locations for accessibility check. Missing: [Mario Zone 3 - 33 Coins, Mario Zone 3 - 42 Coins, Mario Zone 3 - 40 Coins, Mario Zone 3 - 41 Coins, Mario Zone 3 - 47 Coins, Mario Zone 3 - 37 Coins, Mario Zone 3 - 32 Coins, Mario Zone 3 - 31 Coins, Mario Zone 3 - 45 Coins, Mario Zone 3 - 38 Coins, Mario Zone 3 - 34 Coins, Mario Zone 3 - 35 Coins, Mario Zone 3 - 43 Coins, Mario Zone 3 - 30 Coins, Mario Zone 3 - 44 Coins, Mario Zone 3 - 46 Coins, Mario Zone 3 - 36 Coins, Mario Zone 3 - 39 Coins]

Seed: 19246233477726224197

Exception: Could not access required locations for accessibility check. Missing: [Mario Zone 3 - 31 Coins, Mario Zone 3 - 44 Coins, Mario Zone 3 - 45 Coins, Mario Zone 3 - 37 Coins, Mario Zone 3 - 39 Coins, Mario Zone 3 - 46 Coins, Mario Zone 3 - 40 Coins, Mario Zone 3 - 43 Coins, Mario Zone 3 - 36 Coins, Mario Zone 3 - 35 Coins, Mario Zone 3 - 32 Coins, Mario Zone 3 - 34 Coins, Mario Zone 3 - 47 Coins, Mario Zone 3 - 38 Coins, Mario Zone 3 - 33 Coins, Mario Zone 3 - 41 Coins, Mario Zone 3 - 30 Coins, Mario Zone 3 - 42 Coins]

Seed: 55051236482054671527

Exception: Could not access required locations for accessibility check. Missing: [Mario Zone 3 - 34 Coins, Mario Zone 3 - 45 Coins, Mario Zone 3 - 36 Coins, Mario Zone 3 - 46 Coins, Mario Zone 3 - 44 Coins, Mario Zone 3 - 38 Coins, Mario Zone 3 - 42 Coins, Mario Zone 3 - 40 Coins, Mario Zone 3 - 35 Coins, Mario Zone 3 - 30 Coins, Mario Zone 3 - 39 Coins, Mario Zone 3 - 33 Coins, Mario Zone 3 - 47 Coins, Mario Zone 3 - 43 Coins, Mario Zone 3 - 37 Coins, Mario Zone 3 - 41 Coins, Mario Zone 3 - 31 Coins, Mario Zone 3 - 32 Coins]

Seed: 50671643921938774021

Exception: Could not access required locations for accessibility check. Missing: [Mario Zone 3 - 42 Coins, Mario Zone 3 - 32 Coins, Mario Zone 3 - 34 Coins, Mario Zone 3 - 44 Coins, Mario Zone 3 - 46 Coins, Mario Zone 3 - 33 Coins, Mario Zone 3 - 40 Coins, Mario Zone 3 - 31 Coins, Mario Zone 3 - 35 Coins, Mario Zone 3 - 41 Coins, Mario Zone 3 - 38 Coins, Mario Zone 3 - 47 Coins, Mario Zone 3 - 37 Coins, Mario Zone 3 - 43 Coins, Mario Zone 3 - 36 Coins, Mario Zone 3 - 30 Coins, Mario Zone 3 - 39 Coins, Mario Zone 3 - 45 Coins]

Seed: 78301089125151606985

Exception: Could not access required locations for accessibility check. Missing: [Mario Zone 3 - 32 Coins, Mario Zone 3 - 40 Coins, Mario Zone 3 - 37 Coins, Mario Zone 3 - 38 Coins, Mario Zone 3 - 46 Coins, Mario Zone 3 - 43 Coins, Mario Zone 3 - 47 Coins, Mario Zone 3 - 36 Coins, Mario Zone 3 - 39 Coins, Mario Zone 3 - 34 Coins, Mario Zone 3 - 31 Coins, Mario Zone 3 - 35 Coins, Mario Zone 3 - 44 Coins, Mario Zone 3 - 42 Coins, Mario Zone 3 - 41 Coins, Mario Zone 3 - 45 Coins, Mario Zone 3 - 33 Coins, Mario Zone 3 - 30 Coins]

Mario Zone 3 and Pumpkin Zone 1 coin issues should be fixed

@Exempt-Medic
Copy link
Member

Mario Zone 3 and Pumpkin Zone 1 coin issues should be fixed

I get a different error now:

    ...\Archipelago\worlds\marioland2\__init__.py", line 200, in create_regions
    coin_thresholds = self.random.sample(range(1, self.max_coin_locations[level] + 1), coins)
                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    ...\Python\Python311\Lib\random.py", line 456, in sample
    raise ValueError("Sample larger than population or is negative")
ValueError: Sample larger than population or is negative

@Exempt-Medic
Copy link
Member

Mario Zone 3 and Pumpkin Zone 1 coin issues should be fixed

I get a different error now:

    ...\Archipelago\worlds\marioland2\__init__.py", line 200, in create_regions
    coin_thresholds = self.random.sample(range(1, self.max_coin_locations[level] + 1), coins)
                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    ...\Python\Python311\Lib\random.py", line 456, in sample
    raise ValueError("Sample larger than population or is negative")
ValueError: Sample larger than population or is negative

This is caused because max_coin_locations can now be 0. https://github.com/Alchav/Archipelago/blob/mario-land-2/worlds/marioland2/locations.py#L488
Which makes you sample an empty range

@Exempt-Medic
Copy link
Member

I did 100 solo-player max-coinsanity generations and was going to do 100 25-player generations. On gen 20 I got this error:

File "...\worlds\marioland2\__init__.py", line 432, in create_item
    return MarioLand2Item(name, items[name], self.item_name_to_id[name], self.player)
                                ~~~~~^^^^^^
KeyError: '213 Coins'

weights.json

There's the yaml, seed was 44097339916776876266

@Exempt-Medic
Copy link
Member

Got another one on gen 31 (these gens take a while) "KeyError: '286 Coins'"
Seed: 72698586421204968430

@Exempt-Medic
Copy link
Member

Another one (gen 33) "KeyError: '289 Coins'"
Seed: 31790366947071009253

@Exempt-Medic
Copy link
Member

And a double wammy (gens 40 and 41): "KeyError: '320 Coins'"
Seed: 52739574766450215686
"KeyError: '230 Coins'"
Seed: 19383545580789475530

@Exempt-Medic
Copy link
Member

Made it to gen 49, gonna just stop here.
KeyError: '212 Coins'
Seed: 40591627474227425253

@Alchav
Copy link
Contributor Author

Alchav commented Dec 5, 2024

I did 100 solo-player max-coinsanity generations and was going to do 100 25-player generations. On gen 20 I got this error:

File "...\worlds\marioland2\__init__.py", line 432, in create_item
    return MarioLand2Item(name, items[name], self.item_name_to_id[name], self.player)
                                ~~~~~^^^^^^
KeyError: '213 Coins'

weights.json

There's the yaml, seed was 44097339916776876266

Should be fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is: new game Pull requests for implementing new games into Archipelago. waiting-on: author Issue/PR is waiting for feedback or changes from its author. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants