Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: update requirements #2716

Merged
merged 3 commits into from
Feb 19, 2024
Merged

Core: update requirements #2716

merged 3 commits into from
Feb 19, 2024

Conversation

Berserker66
Copy link
Member

What is this fixing or adding?

updates various modules

How was this tested?

tested kivy on Python 3.12, didn't test much else yet.

If this makes graphical changes, please attach screenshots.

@black-sliver black-sliver mentioned this pull request Jan 13, 2024
@black-sliver
Copy link
Member

Hm, wanted to make sure colorama is still working, but turns out python CommonClient.py --nogui is not working for me.

Jinja, platformdirs and cython looks safe.
I tested kivy on Linux in 2718.

@Berserker66
Copy link
Member Author

In what way is it not working for you? Seems fine on Windows 10.

@black-sliver
Copy link
Member

black-sliver commented Jan 13, 2024

I only get "logging started" and 3 warnings for options api in the terminal and nothing else after that.

@Jarno458 Jarno458 added affects: core Issues/PRs that touch core and may need additional validation. is: maintenance Regular updates to requirements and utilities that do not fix bugs or change/add features. labels Jan 22, 2024
@PoryGone PoryGone added the waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer. label Feb 10, 2024
@@ -1,13 +1,13 @@
colorama>=0.4.5
colorama>=0.4.6
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
colorama>=0.4.6
colorama>=0.4.5

possibly broken on linux?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing to do with colorama.

logger.info() simply does not print to stdout for me, but print() and logger.error() does. host.yaml says loglevel: "info", so that should be fine? Any ideas?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. I guess you could breakpoint into the log function and see where it goes wrong? Again, on my system it all works fine.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Turns out if I add

logger.setLevel(logging.INFO)

right after

logger = logging.getLogger("Client")

I get messages. So it seems like logging.getLogger() has a separate minimum logging level?

Copy link
Member

@black-sliver black-sliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested latest colorama on Linux with #2846

@Berserker66 Berserker66 merged commit 933e5ba into main Feb 19, 2024
21 checks passed
@Berserker66 Berserker66 deleted the core_update_modules branch February 19, 2024 23:25
@github-actions github-actions bot removed the waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer. label Feb 19, 2024
Jouramie pushed a commit to Jouramie/Archipelago that referenced this pull request Feb 28, 2024
TheLX5 pushed a commit to TheLX5/Archipelago that referenced this pull request Mar 2, 2024
TheLX5 pushed a commit to TheLX5/Archipelago that referenced this pull request Mar 2, 2024
EmilyV99 pushed a commit to EmilyV99/Archipelago that referenced this pull request Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects: core Issues/PRs that touch core and may need additional validation. is: maintenance Regular updates to requirements and utilities that do not fix bugs or change/add features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants