-
Notifications
You must be signed in to change notification settings - Fork 713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Add Spanish guide for Clique #2691
Conversation
referencing guide_es.md (hopefully done correctly)
hopefully I did the init.py edit good, it seemed a bit different than the others (edit: ok looks like I messed up) |
ok I think this is fixed now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Init looks good and translation is accurate.
LGTM
I'm about to change a lot of stuff in Clique, so it'll be out dated soon. I would at least wait until I can get v2 finished. I can work with you later on updating the guides. |
ah, I see |
Should this still wait for v2 or can this be put in place while v2 is still in development? Additionally, the branch now has conflicts that would need to be sorted before continuing. |
yeah not sure really, I expected v2 would come sooner by that Phar message |
I think that it would still be worth to keep the PR open if v2 is still far out. Ultimately it's up to @ThePhar if they would want this to be closed or to merge it |
This has conflicts btw |
i'll close this for now, i'll just wait for clique 2.0 to be officially merged to even think about updating the guide again |
What is this fixing or adding?
this adds a spanish setup guide for Clique, the greatest game of all time
How was this tested?
by me translating and proofreading it