Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Add Spanish guide for Clique #2691

Closed
wants to merge 3 commits into from

Conversation

ShinyNT
Copy link
Contributor

@ShinyNT ShinyNT commented Jan 9, 2024

What is this fixing or adding?

this adds a spanish setup guide for Clique, the greatest game of all time

How was this tested?

by me translating and proofreading it

referencing guide_es.md (hopefully done correctly)
@ShinyNT ShinyNT requested a review from ThePhar as a code owner January 9, 2024 03:54
@ShinyNT
Copy link
Contributor Author

ShinyNT commented Jan 9, 2024

hopefully I did the init.py edit good, it seemed a bit different than the others

(edit: ok looks like I messed up)
(edit2: ok it seems it may be good now)
(edit3: YAY all tests passed)

#2301

ok I think this is fixed now
@ScipioWright ScipioWright added the is: documentation Improvements or additions to documentation. label Jan 9, 2024
@PoryGone PoryGone added waiting-on: world-maintainer Issue/PR is waiting for feedback or approval by the maintainer of a world. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Feb 10, 2024
Copy link
Contributor

@nicholassaylor nicholassaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Init looks good and translation is accurate.
LGTM

@ThePhar
Copy link
Member

ThePhar commented Mar 29, 2024

I'm about to change a lot of stuff in Clique, so it'll be out dated soon. I would at least wait until I can get v2 finished. I can work with you later on updating the guides.

@ShinyNT
Copy link
Contributor Author

ShinyNT commented Mar 29, 2024

ah, I see
sure, let's wait until v2 is released

@nicholassaylor
Copy link
Contributor

Should this still wait for v2 or can this be put in place while v2 is still in development? Additionally, the branch now has conflicts that would need to be sorted before continuing.

@ShinyNT
Copy link
Contributor Author

ShinyNT commented Sep 6, 2024

yeah not sure really, I expected v2 would come sooner by that Phar message
I guess I can just close it in the meantime if needed

@nicholassaylor
Copy link
Contributor

I think that it would still be worth to keep the PR open if v2 is still far out. Ultimately it's up to @ThePhar if they would want this to be closed or to merge it

@Exempt-Medic
Copy link
Member

This has conflicts btw

@Exempt-Medic Exempt-Medic added the waiting-on: author Issue/PR is waiting for feedback or changes from its author. label Nov 28, 2024
@ShinyNT
Copy link
Contributor Author

ShinyNT commented Nov 28, 2024

i'll close this for now, i'll just wait for clique 2.0 to be officially merged to even think about updating the guide again

@ShinyNT ShinyNT closed this Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is: documentation Improvements or additions to documentation. waiting-on: author Issue/PR is waiting for feedback or changes from its author. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. waiting-on: world-maintainer Issue/PR is waiting for feedback or approval by the maintainer of a world.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants