-
Notifications
You must be signed in to change notification settings - Fork 705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: update Pokemon R/B spanish guide #2672
Conversation
i'm stupid and actually didn't edit the client chose part lol
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good. Read through and nothing stuck out, corroborated by a quick Google Translate to confirm my understanding. Information is still up-to-date.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spanish isn't my first language, but even passable Spanish shows that these changes bring the guide in line with more recent Archipelago versions, namely with the inclusion of Bizhawk Client, the deprecation of Pokemon Client, and the change to use the Bizhawk connector lua. These changes will immediately reduce the number of tech support requests we get from the outdated guide.
As for the quality of the Spanish, I'm able to read it without being 100% fluent. Future adjustments could be made if there's imprecision, but the guide appears to properly instruct users how to setup Archipelago for patching the game, how to play single player without server functions (if desired), and how to connect to a multiworld server.
Confused why @Alchav was never pinged for this. I'm down to merge this if it's wanted from both sides. |
Oh, this ping was probably not warranted since this is an update to an already existing doc. My bad. |
What is this fixing or adding?
this is updating the pokemon r/b spanish guide, which became a bit obsolete after the 0.4.4 release
essentially I updated the sections about bizhawk client and removed the client chose part on the installation step, so now the guide looks alike with the english one
How was this tested?
by me translating the outdated parts and comparing it with the english guide