Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: update Pokemon R/B spanish guide #2672

Merged
merged 3 commits into from
Nov 28, 2024

Conversation

ShinyNT
Copy link
Contributor

@ShinyNT ShinyNT commented Jan 4, 2024

What is this fixing or adding?

this is updating the pokemon r/b spanish guide, which became a bit obsolete after the 0.4.4 release
essentially I updated the sections about bizhawk client and removed the client chose part on the installation step, so now the guide looks alike with the english one

How was this tested?

by me translating the outdated parts and comparing it with the english guide

i'm stupid and actually didn't edit the client chose part lol
@alwaysintreble alwaysintreble added the is: documentation Improvements or additions to documentation. label Jan 5, 2024
@PoryGone PoryGone added the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label Feb 10, 2024
Copy link
Contributor

@nicholassaylor nicholassaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. Read through and nothing stuck out, corroborated by a quick Google Translate to confirm my understanding. Information is still up-to-date.

Copy link
Contributor

@eudaimonistic eudaimonistic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spanish isn't my first language, but even passable Spanish shows that these changes bring the guide in line with more recent Archipelago versions, namely with the inclusion of Bizhawk Client, the deprecation of Pokemon Client, and the change to use the Bizhawk connector lua. These changes will immediately reduce the number of tech support requests we get from the outdated guide.

As for the quality of the Spanish, I'm able to read it without being 100% fluent. Future adjustments could be made if there's imprecision, but the guide appears to properly instruct users how to setup Archipelago for patching the game, how to play single player without server functions (if desired), and how to connect to a multiworld server.

@NewSoupVi
Copy link
Member

Confused why @Alchav was never pinged for this. I'm down to merge this if it's wanted from both sides.

@NewSoupVi NewSoupVi added waiting-on: world-maintainer Issue/PR is waiting for feedback or approval by the maintainer of a world. and removed waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Nov 28, 2024
@NewSoupVi
Copy link
Member

Oh, this ping was probably not warranted since this is an update to an already existing doc. My bad.

@NewSoupVi NewSoupVi merged commit 78bc7b8 into ArchipelagoMW:main Nov 28, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is: documentation Improvements or additions to documentation. waiting-on: world-maintainer Issue/PR is waiting for feedback or approval by the maintainer of a world.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants