Core: Move Location.always_allow to a subclass #2651
+25
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alwaysintreble
added
is: refactor/cleanup
|
Should probably benchmark this first. If we decide to merge, we should also touch up docs to mention this. |
PoryGone
added
the
waiting-on: author
Berserker66
added
the
meta: help wanted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Moves the always_allow rule to a subclass, mainly in the hopes of improving performance as can_fill is a pretty hot code path.
How was this tested?
Only unittests so far, which did run faster, but more testing especially for performance should be done.
If this makes graphical changes, please attach screenshots.