Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core: optimize DeprecateDict #2650

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Core: optimize DeprecateDict #2650

wants to merge 5 commits into from
+5 −5

Conversation

Berserker66
Copy link
Member

What is this fixing or adding?

Makes deprecatedict faster in -O or higher modes
Allows me to remove the absolute spam that is the webhost log before it hits production.

How was this tested?

unittests

If this makes graphical changes, please attach screenshots.

@alwaysintreble
Copy link
Collaborator

this doesn't work for when we properly deprecate the old stuff

@Berserker66
Copy link
Member Author

then we change the code

@black-sliver
Copy link
Member

Can we check if this is used in context of WebHost and avoid generating the warnings just for WebHost?

@Berserker66
Copy link
Member Author

No idea, I deployed prod with this branch.

@alwaysintreble alwaysintreble added is: refactor/cleanup Improvements to code/output readability or organizization. affects: core Issues/PRs that touch core and may need additional validation. labels Jan 5, 2024
@PoryGone PoryGone added the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label Feb 10, 2024
BadMagic100
BadMagic100 approved these changes Jun 8, 2024
View reviewed changes
Copy link
Collaborator

@BadMagic100 BadMagic100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not tested this but the code seems both correct and reasonable to me

agilbert1412
agilbert1412 approved these changes Jun 10, 2024
View reviewed changes
Copy link
Collaborator

@agilbert1412 agilbert1412 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change seems reasonable to me

@agilbert1412 agilbert1412 added waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer. and removed waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Jun 10, 2024
@Exempt-Medic Exempt-Medic added the waiting-on: author Issue/PR is waiting for feedback or changes from its author. label Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agilbert1412 agilbert1412 agilbert1412 approved these changes

@BadMagic100 BadMagic100 BadMagic100 approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
affects: core Issues/PRs that touch core and may need additional validation. is: refactor/cleanup Improvements to code/output readability or organizization. waiting-on: author Issue/PR is waiting for feedback or changes from its author. waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Berserker66 @alwaysintreble @black-sliver @BadMagic100 @agilbert1412 @Exempt-Medic @PoryGone