KH2: Promise charm logic #2635
Merged
KH2: Promise charm logic #2635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this a bug fix? I.e. would it roll unexpected seeds without merging this? |
no, level logic is all "fake". Nothing is stopping the player from getting all the level checks when the seed starts but its insanely long so I scaled it using visit locking items. Promise charm path unlocks a room that allows you to level extremely fast and its a bit weird that the logic doesnt consider it. |
Silvris
reviewed
Dec 28, 2023
ThePhar
added
the
is: refactor/cleanup
Berserker66
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please format your title with what portion of the project this pull request is
targeting and what it's changing.
ex. "MyGame4: implement new game" or "Docs: add new guide for customizing MyGame3"
What is this fixing or adding?
adding a short circuit for promise charm level logic
How was this tested?
rolled a seed with the option being true and it short circuited.
rolled a seed without the option and it didn't short circuit
If this makes graphical changes, please attach screenshots.