SMZ3: optimized message queues #2611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…VariaRandomizer's rules, items, locations and accessPoint (as regions)
…se (fills ROM item table) This is dependant on modifications done to sm_randomizer_rom project
- player name inject in ROM and get in client - end game get from ROM in client - send self item to server - add player names table in ROM
…ition of an array of it (required to generation more than one SM world, which is still fails but is better)
… and done some cleaning
…er's" This reverts commit fb3ca18.
- fixed seeded generation - fixed broken logic when more than one SM world - added missing rules for inter-area transitions - added basic patch presence for logic - added DoorManager init call to reflect present patches for logic - moved CollectionState addition out of BaseClasses into SM world - added condition to apply progitempool presorting only if SM world is present - set Bosses item id to None to prevent them going into multidata - now use get_game_players
…VariaRandomizer's rules, items, locations and accessPoint (as regions)
…se (fills ROM item table) This is dependant on modifications done to sm_randomizer_rom project
- player name inject in ROM and get in client - end game get from ROM in client - send self item to server - add player names table in ROM
…ition of an array of it (required to generation more than one SM world, which is still fails but is better)
… and done some cleaning
mainly for item link linked replacement items and for cheated items now only store itemIndex for sending queue moved all queue pointers, seed data and sent queue at end of SRAM to free up around 0xD30 for receiving queue receiving queue now only use 8 bit for each of player ID and item ID instead of 16 bit each
ScipioWright
added
is: refactor/cleanup
ThePhar
approved these changes
Dec 28, 2023
Jouramie
pushed a commit
to Jouramie/Archipelago
that referenced
this pull request
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
optimized message queues to support more receiving items
mainly for item link linked replacement items and for cheated items
now only store itemIndex for sending queue
moved all queue pointers, seed data and sent queue at end of SRAM to free up around 0xD30 for receiving queue
receiving queue now only use 8 bit for each of player ID and item ID instead of 16 bit each
this should allow for receiving 1688 items which should fix reported issue here: https://discord.com/channels/731205301247803413/1179637870735147069/1179637870735147069
link to asm change of smz3 ips patch: lordlou/alttp_sm_combo_randomizer_rom@0c63472
How was this tested?
I generated a multi with 2 keysanity SMZ3 and verified they can send and receive items properly with the changes, and even after having received over 400 cheated items.