FFMQR: Fix Empty Kaeli Companion Event Location and Spellbook option #2591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alchav
changed the title
Alchav
changed the title
ScipioWright
added
is: bug/fix
Alchav
changed the title
Berserker66
approved these changes
Dec 12, 2023
Jouramie
pushed a commit
to Jouramie/Archipelago
that referenced
this pull request
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Seems the Kaeli Mom Fight Minotaur option is causing failures. I do not know how this got past my initial generation testing. But it seems it results in a rooms.yaml that has this location specified but with no on_trigger which leads it to being created as an empty location (it is an event).
I am awaiting wildham's confirmation that this fix is the correct one, but there will need to be a fix.Should be good.Fixes the Companion Spellbook option as one of the choice's names was not what FFMQR expected, which apparently broke the Progressive Gear option somehow.
How was this tested?
Generating with the options on and ensuring patching succeeds and progressive gear works