Pokemon Emerald: Change "settings" to "options" in docs #2517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ReverM
suggested changes
Nov 28, 2023
Co-authored-by: Aaron Wagener <[email protected]>
|
I have covered the changes in #2622, maybe this PR could be closed then? |
|
This already has reviews and doesn't need to wait on the additional approvals of all other world maintainers, so I think it makes more sense to keep this one. |
|
This pr is also from the world maintainer so takes precedence imo |
black-sliver
approved these changes
Dec 28, 2023
54 tasks
Jouramie
pushed a commit
to Jouramie/Archipelago
that referenced
this pull request
Feb 28, 2024
…W#2517) * Pokemon Emerald: Change "settings" to "options" in docs * Pokemon Emerald: Fix two more usages of "setting" instead of "option" * Pokemon Emerald: Minor rephrase in docs Co-authored-by: Aaron Wagener <[email protected]> --------- Co-authored-by: Aaron Wagener <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Brings the Emerald docs in line with #2037.
How was this tested?
Ran web host, checked pages, clicked links.
If this makes graphical changes, please attach screenshots.