ChecksMate: implement new game #2507
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto checks_mate
…e more queen upgrades in pool than majors though. they shouldn't count for anything if i fix that one function (it might already work)
i am not going to actually support this
… on minimal setting
|
All review comments are resolved. Tests are passing. I am going to review recent player and historical maintainer feedback one more time. I plan to move this PR from draft state to review in the near to immediate future. I am aware of some client issues (in particular that DeathLink doesn't function), but those issues would not impact the generator implementation. |
Exempt-Medic
added
the
waiting-on: peer-review
NewSoupVi
reviewed
Nov 18, 2024
Exempt-Medic
requested changes
Nov 18, 2024
…n __init__? I'm confused what you would need both for
* . * Initial lookthrough, ignoring __init__.py * Restore these back, they're just kinda weird
…nto checks_mate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
ChecksMate is a client for Chess played against a computer-controlled engine. Unique features include pocket pieces, fairy pieces, and random starting positions.
The client is available here: https://github.com/chesslogic/chessv
How was this tested?
Initial testing
When putting this up for draft, the Archipelago community had never played this in any Unsupported multiworld hosted on the Discord server.
Some automated tests are available in the repository regarding some specific settings.
The author has played ChecksMate in 2 "mid-sized" multiworlds (6-15 games), 1 "large-ish" multiworld (30-40 games), and one or two dozen XS multiworlds (2-5 games). The non-XS multiworlds were async, and the XS multiworlds were sync.
Many of these multiworlds involved multiple copies of ChecksMate. ChecksFinder was common to many XS multiworlds.
Community testing
Since then, in addition to recurring off-server multiworlds, Archipelago players from the Discord have participated in 2 multiworlds involving over 50% copies of ChecksMate as well as dozens of asyncs accepting unsupported apworlds. Even players new to chess have been able to successfully complete their game on sufficiently relaxed settings.
The automated tests have been further honed.
If this makes graphical changes, please attach screenshots.
Please be advised that no ChecksMate client is expected to be added to the Archipelago repository. The author provides releases of a ChecksMate client on GitHub, but the client specification may also be implemented by other Chess tools supporting arbitrary fairy chess formats.
The following images have descriptive alt text.