Lingo: Sync config with game update #2447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fixed a warning in the validate config script that should've been handled in an earlier PR.
Fixing this actually has no real effect, but it's good to keep the map accurate.
This actually does matter for logic.
ThePhar
added
the
is: maintenance
|
Do I understand correctly that without this change, rolling on main creates a seed that has different logic than the actual game? |
|
Correct. |
black-sliver
added
the
affects: release/blocker
ThePhar
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
There is an update to the game that slightly changes the topography of the world, so this I've changed the world config to be up to date with that.
Also fixed a warning in the validate config script that should've been handled in an earlier PR.
I asked the dev if he had any other plans to make topological changes soon and he said no.
How was this tested?
pytest and a handful of test runs on different settings.
If this makes graphical changes, please attach screenshots.