Core: update modules #2440
Merged
Core: update modules #2440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThePhar
added
is: maintenance
black-sliver
approved these changes
Nov 12, 2023
There was a problem hiding this comment.
- bsdiff4 adds py3.12 builds, other changes don't concern us
- Cython 3.0.5 changes look safe and it still builds _speedups for me. We may be able to remove our warning suppression, but that's something a windows user will have to verify.
- cx_freeze looks mostly safe. There have been changes to macos, but we don't have anyone testing/maintaining that. Linux + py3.8 and py3.11 still produces mostly1 working builds and include _speedups. One interesting change is hooks: multiprocessing support for forkserver and spawn marcelotduarte/cx_Freeze#1956 , which could allow us to drop our own hook, but I have not tested that yet. Our own hook is still working.
Footnotes
-
Frozen Factorio on py3.8 gives
ModuleNotFoundError: No module named 'orjson.orjson'and frozen hylics2 on py3.8 givesValueError: attempted relative import beyond top-level package, but are unrelated to this change and also happen on main with cx_freeze 6.15.2. ↩
FlySniper
pushed a commit
to FlySniper/Archipelago
that referenced
this pull request
Nov 14, 2023
Jouramie
pushed a commit
to Jouramie/Archipelago
that referenced
this pull request
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
updates some modules
How was this tested?
Not enough. For one thing the linker had to abort compiling _speedups, as the file is currently opened by async gens.
If this makes graphical changes, please attach screenshots.