Tests: Added more specific error messages to the duplicate id asserts #2428
Conversation
Jarno458
added
the
is: refactor/cleanup
|
Every single case where you added the game name already says the relevant game in the test run. |
|
i had a hard time finding it |
|
in pycharm |
|
seems like my test runner doesnt display those subtests like that |
|
Mine doesn't allow me to go to that level, it does still run the test for all games 1 by 1 just fine tho |
|
get a better test runner? No idea which one that even is. |
|
I dont think adding those game names hurt, might help people who use subpar test runners |
ThePhar
added
the
affects: core
Jarno458
force-pushed
the
more_readable_test_errors
branch
from
255157a to
2a86ba0
Compare
Jarno458
changed the title
|
Updated to remove the GameName messages |
| .symmetric_difference(set(world_type.item_name_to_id.keys())) or \ | ||
| set(world_type.item_id_to_name.keys()) \ | ||
| .symmetric_difference(set(world_type.item_name_to_id.values())) | ||
| self.assertFalse(overlap) |
There was a problem hiding this comment.
Not a big fan of this style of creating boolean values and asserting them, when the real check is actually the if. What was wrong with the suggested code above?
agilbert1412
added
the
waiting-on: peer-review
Exempt-Medic
added
the
waiting-on: author
|
Oke lets close this i guess |
What is this fixing or adding?
Added additional comparisations to the duplicate id's check to actually print out the duplicated ids
How was this tested?
ran them