Core: allow for a single player all_state #2418
Conversation
|
Question: When you say "this gave an additional ~25% increase", that means you went and changed some If so, this is probably worth a world maintainer ping in the Discord or something, like "please switch to get_all_state(player) if your implementation allows it" Anyway, lgtm but I don't think I have the core knowledge to be sure that it's right |
|
|
||
| if use_cache: | ||
| self._all_state = ret | ||
| if player: | ||
| setattr(self, f"_all_state{player}", None) |
There was a problem hiding this comment.
lmao oops. i was testing it with a cache then temp removed it to find a bug and put it back wrong
i tested it under the same conditions as the linked PR |
|
While I like this idea, think I'm going to close this and reimplement it as a full API change |
What is this fixing or adding?
allows a world to provide a player to
multiworld.get_all_state(), building an all_state that only has the items and sweeps the locations of that player. This also fixes an existing bug withget_all_statewhere it returns the actual state the first time it gets built instead of a copy of it, allowing extra items to be added to the pool.How was this tested?
hours of debugging 😔
Tested in combination with #2415 and this gave an additional ~25% speed increase. for 300 worlds using pre_fill methods
If this makes graphical changes, please attach screenshots.