Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MultiServer: Create read-only data storage key for client statuses. #2412

Merged
merged 1 commit into from
Nov 24, 2023

Conversation

ThePhar
Copy link
Member

@ThePhar ThePhar commented Nov 1, 2023

What is this fixing or adding?

Implements a new read-only data storage key _read_client_status_{team}_{slot} which returns the ClientStatus of a particular slot. Also adds the relevant documentation.

How was this tested?

Tested with a test client using Archipelago.js.

Retrieve:
image

SetNotify & StatusUpdate:
image
image

SetNotify & StatusUpdate from another client, SetNotify event fired:
image

image

If this makes graphical changes, please attach screenshots.

N/A

@ThePhar
Copy link
Member Author

ThePhar commented Nov 1, 2023

If anyone is curious of why this could be useful, this can be utilized by clients for an in-game ready system and allow any toggling to update UI in real-time for all other players connected. Can also be used to see in-game of any other players who have completed their goal without needing to explicitly listen for Goal PrintJSON, which requires players to be connected to even listen for it anyway.

@ThePhar ThePhar added is: documentation Improvements or additions to documentation. is: enhancement Issues requesting new features or pull requests implementing new features. affects: core Issues/PRs that touch core and may need additional validation. labels Nov 1, 2023
@ThePhar ThePhar merged commit e46420f into ArchipelagoMW:main Nov 24, 2023
12 checks passed
@ThePhar ThePhar deleted the client_status_data_storage branch November 24, 2023 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects: core Issues/PRs that touch core and may need additional validation. is: documentation Improvements or additions to documentation. is: enhancement Issues requesting new features or pull requests implementing new features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants