Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CommonClient: fix json prints not being logged in UI mode #2253

Merged
merged 2 commits into from
Oct 8, 2023
Merged

CommonClient: fix json prints not being logged in UI mode #2253

merged 2 commits into from
Oct 8, 2023

Conversation

Berserker66
Copy link
Member

What is this fixing or adding?

fix json prints not being logged in UI mode

How was this tested?

quickly

If this makes graphical changes, please attach screenshots.

black-sliver
black-sliver requested changes Oct 2, 2023
View reviewed changes
Copy link
Member

@black-sliver black-sliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope

also the log contains the ansi terminal color codes. not sure if that is wanted or not, but i would've expected the log to be plain text?

@Berserker66
Copy link
Member Author

That turned more complex than I initially thought, but I should have it now:
image

@black-sliver
Copy link
Member

Sorry, didn't find time to actually run it this morning. I'll test it tonight, but
do exceptions still show up in the UI now? I feel like that relied on the UI being connected to the logger, and we filter the logger now?

@Berserker66
Copy link
Member Author

I have not tested that yet either.

black-sliver
black-sliver approved these changes Oct 7, 2023
View reviewed changes
Copy link
Member

@black-sliver black-sliver left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When doing a bad /connect, I see OSError: Multiple exceptions: [Errno 111] Connect call failed ('::1', 1234, 0, 0), [Errno 111] Connect call failed ('127.0.0.1', 1234) in the log and terminal, and a MessageBox in the GUI, so that should be fine.

@Berserker66 Berserker66 merged commit cc2247b into main Oct 8, 2023
21 checks passed
@Berserker66 Berserker66 deleted the commonclient_message_log branch October 8, 2023 11:26
@ThePhar ThePhar added is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. affects: core Issues/PRs that touch core and may need additional validation. labels Oct 17, 2023
FlySniper pushed a commit to FlySniper/Archipelago that referenced this pull request Nov 14, 2023
@Berserker66 @FlySniper
CommonClient: fix json prints not being logged in UI mode (Archipelag…
dd15ca9 
…oMW#2253)
Jouramie pushed a commit to Jouramie/Archipelago that referenced this pull request Feb 28, 2024
@Berserker66 @Jouramie
CommonClient: fix json prints not being logged in UI mode (Archipelag…
49b7850 
…oMW#2253)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@black-sliver black-sliver black-sliver approved these changes

Assignees
No one assigned
Labels
affects: core Issues/PRs that touch core and may need additional validation. is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Berserker66 @black-sliver @ThePhar