Core: Provide a better error message if only weights.yaml is provided with players: 0 #2227
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
A user in the discord had some confusion because they had named their player YAML file
weights.yaml
. Since this is the generic weights file and the user had not specified the number of players or provided any other files, the number of players was 0. But, since there was a weights file, theif not weights_cache:
check did not raise an Exception. It wasn't until checking for slot name uniqueness that things blew up, with a very confusing error.How was this tested?
Put a weights.yaml in the Players folder and ran Generate.py.
Before:
After: