-
Notifications
You must be signed in to change notification settings - Fork 728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WebHost, Core: Developer-defined game option presets. #2143
Merged
Merged
Changes from 4 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
093d66b
WebHost: Developer-defined game option presets.
ThePhar 3bfc902
Tweak name
ThePhar 657e415
Optimize imports
ThePhar 0393c4c
Fix possible gen issue
ThePhar 80a8510
Merge branch 'main' into game_option_presets
ThePhar c1e6abd
Layout improvements
ThePhar 085d8b6
Fix number in ranges not updating on reload/preset.
ThePhar bcee9a8
Add validation and clean up of some presets for RL.
ThePhar 23cf8de
Add documentation.
ThePhar a34a27b
Revert accidental change.
ThePhar d2fbd89
Additional edge cases, variable name changes, and some tweaks to UI.
ThePhar 36f6745
Small style tweak to line up meta options with game options.
ThePhar 6b8e537
"optimize" an assert
ThePhar 3714af0
More tweaks to tests
ThePhar c731a50
Doc tweak.
ThePhar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,56 @@ | ||
from typing import Any, Dict | ||
|
||
rl_option_presets: Dict[str, Dict[str, Any]] = { | ||
"All Random": { | ||
"progression_balancing": "random", | ||
"accessibility": "random", | ||
"starting_gender": "random", | ||
"starting_class": "random", | ||
"new_game_plus": "random", | ||
"fairy_chests_per_zone": "random", | ||
"chests_per_zone": "random", | ||
"universal_fairy_chests": "random", | ||
"universal_chests": "random", | ||
"vendors": "random", | ||
"architect": "random", | ||
"architect_fee": "random", | ||
"disable_charon": "random", | ||
"require_purchasing": "random", | ||
"progressive_blueprints": "random", | ||
"gold_gain_multiplier": "random", | ||
"number_of_children": "random", | ||
"free_diary_on_generation": "random", | ||
"khidr": "random", | ||
"alexander": "random", | ||
"leon": "random", | ||
"herodotus": "random", | ||
"health_pool": "random", | ||
"mana_pool": "random", | ||
"attack_pool": "random", | ||
"magic_damage_pool": "random", | ||
"armor_pool": "random", | ||
"equip_pool": "random", | ||
"crit_chance_pool": "random", | ||
"crit_damage_pool": "random", | ||
"allow_default_names": True, | ||
"death_link": "random", | ||
}, | ||
"Limited Resources": { | ||
"progression_balancing": 0, | ||
"fairy_chests_per_zone": 2, | ||
"chests_per_zone": 30, | ||
"vendors": "normal", | ||
"architect": "disabled", | ||
"gold_gain_multiplier": "half", | ||
"number_of_children": 2, | ||
"free_diary_on_generation": False, | ||
"health_pool": 10, | ||
"mana_pool": 10, | ||
"attack_pool": 10, | ||
"magic_damage_pool": 10, | ||
"armor_pool": 5, | ||
"equip_pool": 10, | ||
"crit_chance_pool": 0, | ||
"crit_damage_pool": 0, | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This case does exactly the same thing as the default case, it's therefore not necessary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Negative, because it would output
Generated by https://archipelago.gg with the __default preset.
because it uses the value (not the display name).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And I don't want that :P
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In that case, if __default and __custom include the leading underscores, would other presets also include it? Should it maybe get trimmed away here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other preset names shouldn't have the leading underscores.