-
Notifications
You must be signed in to change notification settings - Fork 708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kirby's Dream Land 3: Implement New Game #2119
Changes from 223 commits
eee9551
1e9e3a0
dee4184
6e0fb28
8f94a5d
79f4f18
544dd36
1856ad1
42dacac
d0767fe
fa51e86
94be3cb
d47fd03
45d551a
d9eda8f
0c9ed0a
0090587
9babd71
69bf348
d3977ba
c603535
f2b58f7
87458b2
4335f92
5a9d778
a79a447
c089927
5e11827
92623ce
fad5897
29bdda5
569a280
21796da
228bd67
b9fc58a
9500094
1f42851
25fa6b0
a9dfd27
90fd5a6
260296e
e8a156b
dcbd08b
0c0c359
b05d0bb
1665520
3374658
dfe6887
0dda27b
3f49f17
37a5410
1a9ac7c
91df55b
aa03b8c
a55feb6
2f8e923
4651eb3
b8231d8
7208132
e42f1a7
4605ed5
f1f7f3e
b0b511c
047aacd
9e6c823
13ba20a
7fd3407
92798b6
e2f5363
3c423f4
66c6c7e
6a07bee
6816d39
f949e02
92d2043
6b7dc70
7dfee5a
426425c
8b52d35
c921e7e
dd96c07
c15f5d3
08a02ed
f220157
a696971
db2a876
5ef29d7
6878acf
a0c6a4e
7a4b401
6cdc32f
d4d23c4
939eedf
0acb0d5
cc8bc58
f815f47
436def1
b50ff6a
09ec83f
4b29800
dd1921f
7c6d6c0
30d1644
2f47552
eba4b74
6388ffb
127670b
fe2bff6
6948e45
a08a29b
831df7b
b0a20fa
355af8d
ba2283c
e0ab024
dc4595c
d915aa7
f1044c0
75f6995
2515298
67ab09a
2d8d434
8913dae
5739ff1
347e2d9
941ccd1
077ae0c
cf5005a
e4b375b
449c046
6187297
f5d3483
9072035
94dd61e
d3197b1
d683974
65c3d89
82525aa
47d8a74
a0ea84a
a707ae2
511dd67
7378511
dd8a26c
db3acfd
0e1e051
865d898
237cbf6
5be0f6a
d0ec94e
5ad4389
b81d1c3
ec67f7f
383d1c9
05d6cf3
aa9640c
03d26b8
f4ca2ed
3d169d1
3247d45
5c1abf5
9ddb73f
a8d711a
b4bb367
0cbffa8
ab0dcab
619887c
19f0f40
51e4886
6a23c09
21008ac
1d154bb
1e85dc4
f1a6371
c5d4728
d1595b7
60b699b
2d721a2
66d0a3e
372dd75
d4ca900
46a9cbc
1e87336
b1cba1c
d12d31b
9633d2a
a522b8a
8a75570
f6a3530
61b13e2
84228e5
bc425f6
cd47ee5
07407bc
c4ce05b
2861ea1
e20dd1c
88227c9
5ad46d6
7501e01
1e030cb
c338e48
85241fa
9bc6d1f
c36c2e7
b87fb60
67ee035
31c73c1
7d53e6e
06d0fbf
b7cad19
52fd4be
b3ecc45
4480051
146a881
d44d751
9ccd420
78a4512
6fb8258
5eb45dd
fd2e977
54cce42
e1e41b2
e6ea365
21cf675
60ac369
b648729
834b098
2cb2f76
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -161,8 +161,41 @@ into any locations within the game slots named BobsSlaytheSpire and BobsRogueLeg | |
|
||
## Boss Plando | ||
|
||
As this is currently only supported by A Link to the Past, instead of finding an explanation here, please refer to the | ||
Silvris marked this conversation as resolved.
Show resolved
Hide resolved
|
||
relevant guide: [A Link to the Past Plando Guide](/tutorial/A%20Link%20to%20the%20Past/plando/en) | ||
This is currently only supported by A Link to the Past and Kirby's Dream Land 3. Boss plando allows a player to place a | ||
given boss within an arena. Boss plando takes in a list of instructions for placing bosses, separated by a semicolon `;`. | ||
There are three types of placement: direct, full, and shuffle. | ||
* Direct placement takes both an arena and a boss, and places the boss into that arena. | ||
* `Eastern Palace-Trinexx` | ||
* Full placement will take a boss, and place it into as many remaining arenas as possible. | ||
* `King Dedede` | ||
* Shuffle will fill any remaining arenas using a given boss shuffle option, typically to be used as the last instruction. | ||
* `full` | ||
|
||
### Examples | ||
|
||
```yaml | ||
A Link to the Past: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It now recreates the LttP docs here, rather than referring to its guide. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I can definitely trim it some, but I think there should be some LttP examples within the main guide since that will still likely be the most prominent use of boss plando. Maybe just leave off the last LttP example? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Well, I suppose this will be stuck until someone who reviews docs looks at it. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. didn't mention it in my original review but i did look through this and it seems fine to me. the generic doc should definitely have examples in it and these are reasonable. yes the lttp doc also have boss shuffle examples but these are the only two games that support boss plando so it's still relevant imo. |
||
boss_shuffle: | ||
# Basic boss shuffle, but prevent Trinexx from being outside Turtle Rock | ||
Turtle Rock-Trinexx;basic: 1 | ||
# Place as many Arrghus as possible, then let the rest be random | ||
Arrghus;chaos: 1 | ||
# Ensure that GT bottom is Kholdstare, then place Trinexx | ||
# into as many arenas as possible, then fill the rest with Kholdstare | ||
# Any remaining arenas will have their vanilla bosses placed | ||
Ganons Tower Bottom-Kholdstare;Trinexx;Kholdstare: 1 | ||
|
||
Kirby's Dream Land 3: | ||
boss_shuffle: | ||
# Ensure Iceberg's boss will be King Dedede, but randomize the rest | ||
Iceberg-King Dedede;full: 1 | ||
# Have all bosses be Whispy Woods | ||
Whispy Woods: 1 | ||
# Ensure Ripple Field's boss is Pon & Con, but let the method others | ||
# are placed with be random | ||
Ripple Field-Pon & Con;random: 1 | ||
``` | ||
|
||
|
||
## Text Plando | ||
|
||
|
@@ -184,7 +217,7 @@ its [plando guide](/tutorial/A%20Link%20to%20the%20Past/plando/en#connections). | |
|
||
[A Link to the Past connections](https://github.com/ArchipelagoMW/Archipelago/blob/main/worlds/alttp/EntranceShuffle.py#L3852) | ||
|
||
[Minecraft connections](https://github.com/ArchipelagoMW/Archipelago/blob/main/worlds/minecraft/Regions.py#L62) | ||
[Minecraft connections](https://github.com/ArchipelagoMW/Archipelago/blob/main/worlds/minecraft/data/regions.json#L18****) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should you be changing minecraft documentation for a Kirby PR? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I figured if we have to edit the file, might as well fix the dead link. This isn't Minecraft documentation though, as it's just a generic plando guide. |
||
|
||
### Examples | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't really belong in this PR but mostly making this comment as I'm noticing it. We should probably make this a vertical layout, so it's easier to avoid conflicts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the approach BizhawkClient takes (where it grabs the extensions of every valid client it can find) would be better in the long run. Out of scope here though, yeah.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While I agree I took a glance at it not too long ago and though sniclient is closer than it used to be, it's still quite a bit of work away from being functional as an apworld