Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Landstalker: implement new game #1808
Landstalker: implement new game #1808
Changes from 49 commits
443fbd3
971694d
0ccc0f5
c86b0a0
1947c14
885abd5
3fc1499
e2e021d
7a51692
c94613b
9e1575e
34f8906
0420e3b
1b21918
816e433
25cbe3b
e9ef3a4
1b66a6b
d1f467e
47759a4
a9e977e
5fa5102
a5deb47
82b0ba9
f199b67
dfcb9e8
e2f6380
cff41e2
be4466d
70f53bf
4ffbb79
909b26b
8e2000f
6eec3a1
0b41b71
e8a900e
d7626c1
46141e2
22e1832
71c14ae
3684042
0cdac77
d6a28a0
86bc405
c4d146c
e33774a
ada1ab9
4f9e99a
f8593c6
f351da6
d0fedd5
ecdef81
e0c5e53
e9b0ef6
fbe5c78
b9dcbf8
41421f2
89f7774
66706af
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think this id could be dropped entirely if you referenced your datapackage on item creation, for the ID, and enumerated in your build function at the bottom here. Messenger does exactly this if you want an example. Obviously not necessary, just reduces some data pollution.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not an expert on how datapackage is handled internally, I'm not against that change but I wouldn't know how to proceed to do so. I didn't find anything related to this in Messenger, I probably didn't look well :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mmm i think random.choices, using those numbers as weights would be better. This is also done in Messenger lol.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure I understand what would any method from the
Random
class accomplish here, since we are just building a simple matching table.The way you do it in messenger is as follows :