SNIClient, ALttP: Add "death_text" to SNIContext's handle_deathlink_state #1793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThePhar
added
is: enhancement
el-u
approved these changes
Sep 2, 2023
Berserker66
approved these changes
Oct 31, 2023
FlySniper
pushed a commit
to FlySniper/Archipelago
that referenced
this pull request
Nov 14, 2023
Jouramie
pushed a commit
to Jouramie/Archipelago
that referenced
this pull request
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please format your title with what portion of the project this pull request is
targeting and what it's changing.
ex. "MyGame4: implement new game" or "Docs: add new guide for customizing MyGame3"
What is this fixing or adding?
Adds a new argument to SNIContext's "handle_deathlink_state" that is then fed into "send_death", allowing worlds utilizing SNIClient to set custom deathlink messages.
This also includes a change to ALttP to utilize this new argument.
How was this tested?
Manually, by generating a multiworld with ALttP and Super Metroid, both with deathlink enabled. Confirmed that the ALttP player's deathlinks sent with the custom message, while the Super Metroid player's deathlinks sent with the default "" (appearing as "Received from Player2").
No automated testing was added.
If this makes graphical changes, please attach screenshots.