Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Launcher: install apworld #1754

Closed
wants to merge 2 commits into from
Closed

Launcher: install apworld #1754

wants to merge 2 commits into from

Conversation

Berserker66
Copy link
Member

What is this fixing or adding?

allows installation of apworlds via Launcher

How was this tested?

by turning subnautica into an apworld and running the new Launcher commands

This is a draft as plenty of things need addressing first:

  • worlds.folder might not be writable on linux(?)
  • tests should be run, however currently importing an already loaded world will quickly fail, so a new Process might need to be started to import just that world and run tests (new executable in frozen state?)
  • user confirmation should be gathered and a warning about executable code contained should be displayed

@Berserker66 Berserker66 changed the title Launcher install apworld Launcher: install apworld Apr 22, 2023
@ThePhar ThePhar added is: enhancement Issues requesting new features or pull requests implementing new features. affects: core Issues/PRs that touch core and may need additional validation. labels May 31, 2023
@eudaimonistic
Copy link
Contributor

Is this now obsolete after #3472 was merged?

@Berserker66 Berserker66 closed this Jun 9, 2024
@Berserker66 Berserker66 deleted the launcher_install_apworld branch June 9, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
affects: core Issues/PRs that touch core and may need additional validation. is: enhancement Issues requesting new features or pull requests implementing new features.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Berserker66 @eudaimonistic @ThePhar