Skip to content

Commit

Permalink
remove ChecksFinder from the list of shame
Browse files Browse the repository at this point in the history
  • Loading branch information
alwaysintreble committed Oct 8, 2023
1 parent 4c4a49c commit febe999
Showing 1 changed file with 5 additions and 4 deletions.
9 changes: 5 additions & 4 deletions test/general/TestItems.py
Original file line number Diff line number Diff line change
Expand Up @@ -64,14 +64,15 @@ def testItemPoolNotModified(self):
"""Test that worlds don't modify the itempool after `create_items`"""
gen_steps = ("generate_early", "create_regions", "create_items")
additional_steps = ("set_rules", "generate_basic", "pre_fill")
excluded_games = ("ChecksFinder", "Links Awakening DX", "Ocarina of Time", "SMZ3")
excluded_games = ("Links Awakening DX", "Ocarina of Time", "SMZ3")
worlds_to_test = {game: world
for game, world in AutoWorldRegister.world_types.items() if game not in excluded_games}
for game_name, world_type in worlds_to_test.items():
with self.subTest("Game", game=game_name):
multiworld = setup_solo_multiworld(world_type, gen_steps)
created_items = multiworld.itempool.copy()
for step in additional_steps:
call_all(multiworld, step)
self.assertEqual(created_items, multiworld.itempool,
f"{game_name} modified the itempool during {step}")
with self.subTest("step", step=step):
call_all(multiworld, step)
self.assertEqual(created_items, multiworld.itempool,
f"{game_name} modified the itempool during {step}")

0 comments on commit febe999

Please sign in to comment.