Small style/efficiency changes

ArchipelagoMW · Jul 6, 2024 · 6ed17b8 · 6ed17b8
1 parent 71fdc65
commit 6ed17b8
Showing 1 changed file with 12 additions and 10 deletions.
diff --git a/worlds/dark_souls_3/__init__.py b/worlds/dark_souls_3/__init__.py
@@ -1221,15 +1221,16 @@ def _add_unnecessary_location_rules(self) -> None:
         all_locations = self.multiworld.get_locations(self.player)
 
         unnecessary_locations = (
-            {
-                location.name
-                for location in all_locations
-                if location.name in self.all_excluded_locations
-                and not (
-                    location.data.missable
-                    and self.options.excluded_location_behavior < self.options.missable_location_behavior
-                )
-            }
+            (
+                {
+                    location.name
+                    for location in all_locations
+                    if location.name in self.all_excluded_locations
+                    and not location.data.missable
+                }
+                if self.options.excluded_location_behavior < self.options.missable_location_behavior
+                else self.all_excluded_locations
+            )
             if self.options.excluded_location_behavior == "unnecessary"
             else set()
         ).union(
@@ -1239,7 +1240,8 @@ def _add_unnecessary_location_rules(self) -> None:
                 if location.data.missable
                 and not (
                     location.name in self.all_excluded_locations
-                    and self.options.missable_location_behavior < self.options.excluded_location_behavior
+                    and self.options.missable_location_behavior <
+                        self.options.excluded_location_behavior
                 )
             }
             if self.options.missable_location_behavior == "unnecessary"