Skip to content

Commit

Permalink
- Split long tests from fill tests
Browse files Browse the repository at this point in the history
  • Loading branch information
agilbert1412 committed Jan 26, 2024
1 parent 8ca6f05 commit 6cb5ecb
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
7 changes: 5 additions & 2 deletions worlds/stardew_valley/test/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ class SVTestCase(unittest.TestCase):
world: StardewValleyWorld
player: ClassVar[int] = 1
# Set False to not skip some 'extra' tests
skip_extra_tests: bool = True
skip_base_tests: bool = True
# Set False to run tests that take long
skip_long_tests: bool = True

Expand All @@ -210,6 +210,9 @@ class SVTestCase(unittest.TestCase):
@classmethod
def setUpClass(cls) -> None:
super().setUpClass()
base_tests_key = "base"
if base_tests_key in os.environ:
cls.skip_base_tests = not bool(os.environ[base_tests_key])
long_tests_key = "long"
if long_tests_key in os.environ:
cls.skip_long_tests = not bool(os.environ[long_tests_key])
Expand All @@ -225,7 +228,7 @@ def world_setup(self, *args, **kwargs):

@property
def run_default_tests(self) -> bool:
if self.skip_long_tests:
if self.skip_base_tests:
return False
# world_setup is overridden, so it'd always run default tests when importing SVTestBase
is_not_stardew_test = type(self) is not SVTestBase
Expand Down
2 changes: 0 additions & 2 deletions worlds/stardew_valley/test/mods/TestMods.py
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,6 @@ def test_given_mod_names_when_generate_paired_with_entrance_randomizer_then_basi
multiworld = setup_solo_multiworld({EntranceRandomization.internal_name: EntranceRandomization.options[option], Mods: mod})
basic_checks(self, multiworld)
check_stray_mod_items(mod, self, multiworld)
# if self.skip_extra_tests:
# return # assume the rest will work as well

def test_allsanity_all_mods_when_generate_then_basic_checks(self):
multi_world = setup_solo_multiworld(allsanity_options_with_mods())
Expand Down

0 comments on commit 6cb5ecb

Please sign in to comment.