Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debugging dunder escape #3

Merged
merged 12 commits into from
Oct 16, 2024
Merged

Debugging dunder escape #3

merged 12 commits into from
Oct 16, 2024

Conversation

tclose
Copy link
Contributor

@tclose tclose commented Oct 16, 2024

  • fixed frametree_home scoping in conftest
  • moves path2label into frametree core
  • adds internal_upload option to XnatViaCS and sets API as the default upload method
  • type annotations

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

Attention: Patch coverage is 83.63636% with 9 lines in your changes missing coverage. Please review.

Project coverage is 81.57%. Comparing base (71621b9) to head (44a4852).
Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
frametree/xnat/cs.py 70.96% 5 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main       #3      +/-   ##
==========================================
+ Coverage   78.37%   81.57%   +3.20%     
==========================================
  Files           4        4              
  Lines         370      380      +10     
  Branches       68       49      -19     
==========================================
+ Hits          290      310      +20     
+ Misses         65       57       -8     
+ Partials       15       13       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tclose tclose merged commit b57ca83 into main Oct 16, 2024
6 checks passed
@tclose tclose deleted the debugging-dunder-escape branch October 16, 2024 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant