Dahyeonryu #20
Open
Dahyeonryu #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gimlocal
approved these changes
Nov 15, 2024
Assets/EnemySpawner.cs
Outdated
| } | ||
|
|
||
| // �ڷ�ƾ�� ����Ͽ� while��ó�� �������� ���� ���� | ||
| IEnumerator SpawnEnemies() |
Assets/Missile.cs
Outdated
| public float speed = 10f; | ||
| public int num = 0; | ||
| // Start is called before the first frame update | ||
| void Start() |
Assets/PlayerController.cs
Outdated
| float moveHorizontal = Input.GetAxis("Horizontal"); | ||
| float moveVertical = Input.GetAxis("Vertical"); | ||
| Vector2 movement = new Vector2(moveHorizontal, moveVertical); | ||
| transform.Translate(movement * moveSpeed * Time.deltaTime); |
There was a problem hiding this comment.
플레이어가 움직이는 코드들을 하나의 함수로 묶어서, Update함수에서는 PlayerMove와 같은 하나의 함수만 작성하는게 더 깔끔한 코드가 될거 같습니다.
Assets/PlayerController.cs
Outdated
| } | ||
|
|
||
|
|
||
| void OnTriggerEnter2D(Collider2D other) |
There was a problem hiding this comment.
현재 플레이어가 경험치 구슬을 먹으면 사라지는 코드가 없는거 같은데 의도된 것인지 궁금하네요.
|
그리고 스크립트들 한 폴더에 정리해주시면 감사하겠습니다.. |
|
코멘트 확인 수정 하고 코멘트 달아주시면 merge하겠습니다~ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
변경점 👍
새로 구현한 기능 및 주요 변경점
버그 해결 💊
해결한 버그
리팩토링 🛠
리팩토링 내역
스크린샷 🖼
변경된 부분에 대한 스크린샷
비고 ✏
리뷰어에게 전하는 말 등
사용하지 않은 항목은 모두 지워주세요.