Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Builds multiple versions of the site #185

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

averissimo
Copy link
Contributor

@averissimo averissimo commented Jun 19, 2024

Closes #184

Tested on my own fork https://averissimo.github.io/shiny.telemetry/

Both with this PR (currently active on that site) and with #181

Changes description and improvements over Rhino

  • Header colors were changed as white fonts had a bad score in accessibility
    • See below for accessibility score (we still fail on AAA on 65% opacity for the version number)
  • Builds site for each tag in repo
  • Only looks for valid versions (vX.Y.Z, vX.Y, vX, vX.Y.Z.W, ...)
    • Rejects release candidates and tags that contain non-numeric characters
  • build.R clean ups directories as function calls exit
  • Installs all packages required by build.R
  • Color template of latest is kept over multiple versions
    • Give consistency on documentation

image

Definition of done

  • Have you read the Contributing Guidelines?
  • NEWS.md file has been updated
  • Development version has been bumped (x.y.z.90XX)
  • Issue has been linked with this PR (via Closing keywords or right sidebar under Development)

@averissimo
Copy link
Contributor Author

White font

image

@averissimo averissimo requested a review from jakubnowicki June 19, 2024 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build documentation for each release version
1 participant