Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This should fix the NullPointerException #357

Merged

Conversation

Dani-Koza-AF
Copy link
Collaborator

Null checks added that suppose to fix the issue some clients face.
The native Android SDK is lifecycle aware, hence when for some reason Flutter Activity is detached then (mMethodChannel is set to null) and the native SDK didn't start yet then AppsFlyerRequestListener() will result an onError callback which will throw NullPointerException.

@Dani-Koza-AF Dani-Koza-AF requested a review from al-af October 30, 2024 12:37
@Dani-Koza-AF Dani-Koza-AF added the bug fix fixing a reported bug label Oct 30, 2024
@Dani-Koza-AF
Copy link
Collaborator Author

Fixes issues: #350 , #347 , #345 .

Copy link
Collaborator

@al-af al-af left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Dani-Koza-AF Dani-Koza-AF merged commit 4f4ee27 into development Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fix fixing a reported bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants