Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix dataframe call to only ignore including apps in report if all row… #143

Merged
merged 1 commit into from
May 7, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion backend/output/presentations/cxPptFsoUseCases.py
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,8 @@ def __init__(self, directory: str, filenames: tuple):
self.workbooks[filename] = pd.read_excel(full_path, sheet_name=None)
except Exception as e:
logging.warning(f"Not able to load workbook {filename}")
logging.warning(f"Was it generated to begin with? Ignoring.")
logging.warning(f"Was it generated to begin with? Ignoring. "
f"Continuing with the rest of the workbooks.")

def findSheetByHeader(self, header_name):
result = []
Expand Down
5 changes: 3 additions & 2 deletions backend/output/reports/ConfigurationAnalysisReport.py
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ async def post_process(self, jobFileName):
applicationData.append([application, ranking, []])

self.buildOutput(applicationData, worksheets)
logging.debug(f"Saving ConfigurationAnalysisReport Workbook")
logging.info(f"Saving ConfigurationAnalysisReport Workbook")
self.workbook.close()

def getValuesInColumn(self, sheet, col1_value):
Expand All @@ -65,7 +65,8 @@ def getValuesInColumn(self, sheet, col1_value):
return values

def getListOfApplications(self):
frame = pd.read_excel(self.analysis_sheet, sheet_name='Analysis', engine='openpyxl').dropna()
frame = pd.read_excel(self.analysis_sheet, sheet_name='Analysis',
engine='openpyxl').dropna(how='all')
return frame['name'].tolist()

def overallAppStatus(self, application, tasklist):
Expand Down
Loading