Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new release #153

Merged
merged 27 commits into from
Jul 2, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
ecf72b8
refactor: function to scroll up
Kariamos Jun 14, 2024
478acdb
fix: deleted duplicated row
Kariamos Jun 14, 2024
79a5a53
feat: added edit/create survey button
Kariamos Jun 17, 2024
666e09b
feat: don't show survey button while creating a new campaign
Kariamos Jun 20, 2024
8b8274b
feat: removed unnecessary part and changed button to link
Kariamos Jun 24, 2024
ab789a9
refactor: move surveybutton to a new file
iacopolea Jun 24, 2024
a7a6948
remove unused vars
iacopolea Jun 24, 2024
287d1cd
add resize to textarea
iacopolea Jun 24, 2024
a3ec974
Merge pull request #150 from AppQuality/add-survey-button-cp-edit
iacopolea Jun 24, 2024
e5d7ca7
wip: refactor preselection forms page
iacopolea Jun 24, 2024
7c10db1
wip: refactor preselection form page
Kariamos Jun 25, 2024
5b5f745
refactor: remove unused code
iacopolea Jun 25, 2024
722bb87
chore: remove unused page (jotform feature)
iacopolea Jun 26, 2024
40e567f
wip: add cap field
Kariamos Jun 26, 2024
2234106
wip: add cap logic
iacopolea Jun 26, 2024
11a665f
wip: fixed form validation tests on cap and target input fields
Kariamos Jun 26, 2024
91827ff
Merge pull request #152 from AppQuality/add-cap
iacopolea Jun 28, 2024
2e5f310
Merge pull request #149 from AppQuality/refactor-preselectionform-ons…
iacopolea Jun 28, 2024
6bdc8ff
fix: update link to preselection forms
iacopolea Jun 28, 2024
d040b4e
fix: fixed payload for no testers cap required
Kariamos Jun 28, 2024
f33c70b
Merge pull request #155 from AppQuality/fix-cap-disabled-payload
d-beezee Jun 28, 2024
a4d43c0
fix: added form check to test that cap input is not empty
Kariamos Jun 28, 2024
7d80533
fix: used formik field for the checkbox
Kariamos Jun 28, 2024
2bf05d9
Merge pull request #157 from AppQuality/fix-cap-not-empty-input-test
d-beezee Jul 1, 2024
33e8e24
fix: avoid showing -1 when cap is not set
Kariamos Jun 28, 2024
c4de4f5
Merge pull request #156 from AppQuality/fix-cap-showing-minus-one
d-beezee Jul 1, 2024
2054795
fix: fixed checkbox checked without cap
Kariamos Jul 1, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 8 additions & 9 deletions src/App.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,11 @@ import AdminPayments from "src/pages/Payments";
import Create from "src/pages/Popups/Create";
import List from "src/pages/Popups/List";
import Update from "src/pages/Popups/Update";
import CampaignPreselection from "src/pages/campaigns/preselectionForm";
import NewPreselectionForm from "src/pages/preselectionForms/new";
import EditPreselectionForm from "src/pages/preselectionForms/edit";
import { setupStore } from "src/store";
import { PageTemplate } from "./features/PageTemplate";
import SentryWrapper from "./features/SentryWrapper";
import Jotform from "./pages/Jotform";
import Prospect from "./pages/Prospect";
import UxDashboard from "./pages/UxDashboard";
import AgreementsList from "./pages/agreements/list";
Expand All @@ -23,7 +23,7 @@ import Campaigns from "./pages/campaigns";
import NewCampaign from "./pages/campaigns/new";
import NewCampaignSuccess from "./pages/campaigns/new/Success";
import EditCampaign from "./pages/campaigns/edit";
import CampaignPreselectionList from "./pages/campaigns/preselectionFormList";
import CampaignPreselectionList from "./pages/preselectionForms";
import SelectionPage from "./pages/campaigns/selection";

const SentryRoute = Sentry.withSentryRouting(Route);
Expand All @@ -49,17 +49,16 @@ function App() {
path="/backoffice/payments"
component={AdminPayments}
/>
<SentryRoute path="/backoffice/jotform" component={Jotform} />
<SentryRoute
path="/backoffice/campaigns/preselection-forms/new"
component={CampaignPreselection}
path="/backoffice/preselection-forms/new"
component={NewPreselectionForm}
/>
<SentryRoute
path="/backoffice/campaigns/preselection-forms/:id"
component={CampaignPreselection}
path="/backoffice/preselection-forms/:id"
component={EditPreselectionForm}
/>
<SentryRoute
path="/backoffice/campaigns/preselection-forms"
path="/backoffice/preselection-forms"
component={CampaignPreselectionList}
/>
<SentryRoute
Expand Down
10 changes: 7 additions & 3 deletions src/features/AuthorizedOnlyContainer.tsx
Original file line number Diff line number Diff line change
@@ -1,14 +1,16 @@
import { Container } from "@appquality/appquality-design-system";
import React from "react";
import ErrorUnauthorized from "src/features/ErrorUnauthorized/ErrorUnauthorized";
import useUserData from "src/pages/Jotform/useUserData";
import { useGetUsersMeQuery } from "src/services/tryberApi";

export const AuthorizedOnlyContainer: React.FC<{
excludeRule: boolean;
children: React.ReactNode;
isFluid?: boolean;
}> = ({ children, excludeRule, isFluid }) => {
const { isFetching, isError, isLoading } = useUserData();
const { isError, isFetching, isLoading } = useGetUsersMeQuery({
fields: "role",
});
if (isLoading || isFetching) return <Container>loading...</Container>;
if (isError) return <Container>there was an error</Container>;
if (excludeRule)
Expand All @@ -23,7 +25,9 @@ export const AuthorizedOnlyContainer: React.FC<{
export const OpsUserContainer: React.FC<{ children: React.ReactNode }> = ({
children,
}) => {
const { data } = useUserData();
const { data } = useGetUsersMeQuery({
fields: "role",
});
return (
<AuthorizedOnlyContainer
excludeRule={data?.role === "tester" || data?.role === "subscriber"}
Expand Down
61 changes: 0 additions & 61 deletions src/pages/Jotform/CufConfigurator/CufConfigurator.tsx

This file was deleted.

51 changes: 0 additions & 51 deletions src/pages/Jotform/CufConfigurator/CufConfiguratorCard.tsx

This file was deleted.

43 changes: 0 additions & 43 deletions src/pages/Jotform/CufConfigurator/CufTextField.tsx

This file was deleted.

43 changes: 0 additions & 43 deletions src/pages/Jotform/CufConfigurator/FocusError.tsx

This file was deleted.

10 changes: 0 additions & 10 deletions src/pages/Jotform/CufConfigurator/FormTitleCard.tsx

This file was deleted.

This file was deleted.

75 changes: 0 additions & 75 deletions src/pages/Jotform/CufConfigurator/useSubmitValues.ts

This file was deleted.

Loading
Loading