-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Find usermountN and set FUSERMOUNT_PROG if not set #82
Conversation
Build for testing: |
Build for testing: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't had a chance to check the find fusermount function fully yet. But the approach itself looks solid and the rest of the code, too. Please see my comments.
So far it works on NixOS by default, which is an improvement over what we had without this PR. However, as soon as one starts experimenting with
it does not use these but uses |
b472526
to
03499e1
Compare
f5a582a
to
e32d176
Compare
Build for testing: |
Works on NixOS. 👍 |
I cleaned up the branch and fixed all remaining issues. I'm not a fan of that search function (too complex and using outdated API), but then again, it works fine for now and it doesn't leak. We still need the patches to FUSE to support the env var. I changed their behavior to demand this input value (which is set by the runtime usually but can be overwritten by the user if needed, albeit we do not want to document any of this). There's also a new debug feature for our FUSE patches. It is what it is. This is the best possible version. @probonopd please open an issue around upstreaming our patch, possibly with some additional modifications. |
Since upstream does not accept feature requests anymore but PRs, we'd need to turn into something suitable for a PR, and I think for that we'd need to make that environment variable optional rather than mandatory. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Pull request authors can't approve their own pull request", but I am happy with this and am advocating for it to be merged. Thanks @TheAssassin
Well...
|
This approach avoids tricky patching of upstream code and exports
FUSERMOUNT_PROG
instead.Closes #15, #16, #31, #32, #35, #36, #37