Skip to content
This repository has been archived by the owner on Feb 9, 2021. It is now read-only.

[JBPM-4951] JBPM Rest API to Create Repository doesnt seem to work #914

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rnetuka
Copy link

@rnetuka rnetuka commented Nov 14, 2017

JIRA: https://issues.jboss.org/browse/JBPM-4951

Missing organizationalUnitName property now returns 400 Bad Request (with explanation) rather than 404 Not Found.

Invalid organizational unit now returns correct Content-Type: text/plain

@kie-ci
Copy link

kie-ci commented Nov 14, 2017

Can one of the admins verify this PR? Comment with 'ok to test' to start the build.

1 similar comment
@kie-ci
Copy link

kie-ci commented Nov 14, 2017

Can one of the admins verify this PR? Comment with 'ok to test' to start the build.

@manstis
Copy link
Contributor

manstis commented Nov 14, 2017

ok to test

@kie-ci
Copy link

kie-ci commented Nov 14, 2017

Can one of the admins verify this PR? Comment with 'ok to test' to start the build.

2 similar comments
@kie-ci
Copy link

kie-ci commented Nov 14, 2017

Can one of the admins verify this PR? Comment with 'ok to test' to start the build.

@kie-ci
Copy link

kie-ci commented Nov 14, 2017

Can one of the admins verify this PR? Comment with 'ok to test' to start the build.

@manstis
Copy link
Contributor

manstis commented Nov 14, 2017

@mswiderski Can you please advise what is considered appropriate for REST changes?

Do you know if this is covered by REVAPI plugin?

@manstis
Copy link
Contributor

manstis commented Nov 14, 2017

@rnetuka Thanks for the PR.

Could you please also provide applicable tests/updated tests?

@kie-ci
Copy link

kie-ci commented Nov 14, 2017

Can one of the admins verify this PR? Comment with 'ok to test' to start the build.

2 similar comments
@kie-ci
Copy link

kie-ci commented Nov 14, 2017

Can one of the admins verify this PR? Comment with 'ok to test' to start the build.

@kie-ci
Copy link

kie-ci commented Nov 14, 2017

Can one of the admins verify this PR? Comment with 'ok to test' to start the build.

@manstis
Copy link
Contributor

manstis commented Nov 14, 2017

Jenkins please execute full downstream build.

@mswiderski
Copy link
Contributor

@manstis I don't think this need any revapi setup as it does not change the api. if needed, it should be documented only that there are erroneous condition and appropriate http status codes are returned to provide meaningful response.

@ederign ederign requested a review from manstis November 15, 2017 12:09
@kie-ci
Copy link

kie-ci commented Nov 16, 2017

Can one of the admins verify this PR? Comment with 'ok to test' to start the build.

Copy link
Contributor

@manstis manstis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awaiting PR for new/updated unit tests on kie-wb-distributions

@ederign
Copy link
Contributor

ederign commented Nov 29, 2017

Can you please move this PR for https://github.com/kiegroup/appformer ?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants