Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support document editing #6842

Open
wants to merge 20 commits into
base: main
Choose a base branch
from
Open

Conversation

qinluhe
Copy link
Collaborator

@qinluhe qinluhe commented Nov 22, 2024

Feature Preview


PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

Copy link

github-actions bot commented Nov 22, 2024

🥷 Ninja i18n – 🛎️ Translations need to be updated

Project /project.inlang

lint rule new reports level link
Missing translation 162 warning contribute (via Fink 🐦)

@qinluhe qinluhe force-pushed the feat/support-document-editing branch from 73883cd to 7ecc1fe Compare November 25, 2024 02:29
@qinluhe qinluhe force-pushed the feat/support-document-editing branch from a1728f5 to 79a7818 Compare November 25, 2024 05:22
@qinluhe qinluhe force-pushed the feat/support-document-editing branch from 79a7818 to 7fe0671 Compare November 25, 2024 05:30
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 40.55944% with 1190 lines in your changes missing coverage. Please review.

Project coverage is 60.48%. Comparing base (7ecf213) to head (236ce77).
Report is 277 commits behind head on main.

Files with missing lines Patch % Lines
...p/src/application/slate-yjs/utils/yjsOperations.ts 33.78% 139 Missing and 6 partials ⚠️
...app/src/application/slate-yjs/utils/slateUtils.tsx 8.78% 135 Missing ⚠️
...wy_web_app/src/components/editor/shortcut.hooks.ts 25.68% 79 Missing and 2 partials ⚠️
...r/components/panels/mention-panel/MentionPanel.tsx 35.34% 72 Missing and 3 partials ⚠️
...ditor/components/panels/slash-panel/SlashPanel.tsx 58.92% 45 Missing and 1 partial ⚠️
...web_app/src/application/slate-yjs/command/index.ts 45.78% 39 Missing and 6 partials ⚠️
.../src/components/_shared/icon-picker/IconPicker.tsx 7.14% 39 Missing ⚠️
.../application/services/js-services/http/http_api.ts 2.63% 37 Missing ⚠️
...p/src/components/_shared/image-upload/Unsplash.tsx 5.55% 34 Missing ⚠️
...ents/toolbar/block-controls/HoverControls.hooks.ts 66.31% 29 Missing and 3 partials ⚠️
... and 61 more
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #6842       +/-   ##
===========================================
- Coverage   74.41%   60.48%   -13.93%     
===========================================
  Files         245      307       +62     
  Lines        6566    12566     +6000     
  Branches     1057     1765      +708     
===========================================
+ Hits         4886     7601     +2715     
- Misses       1628     4760     +3132     
- Partials       52      205      +153     
Flag Coverage Δ
appflowy_web_app 60.48% <40.55%> (-13.93%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@qinluhe qinluhe force-pushed the feat/support-document-editing branch 6 times, most recently from a936af8 to 37ca144 Compare November 25, 2024 11:37
@qinluhe qinluhe force-pushed the feat/support-document-editing branch 6 times, most recently from 2ad9d37 to d021460 Compare November 26, 2024 05:58
@qinluhe qinluhe force-pushed the feat/support-document-editing branch from d021460 to 49dd9ff Compare November 26, 2024 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant