chore: using copy to improve write speed of batch collab api endpoint #862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
appflowy
commented
Oct 6, 2024
appflowy
commented
- use rayon to do decompression and data validation
- using copy instead of insert one by one to postgres in the background queue
Horusiath
reviewed
Oct 6, 2024
| for params in ¶ms_list { | ||
| self | ||
| .access_control | ||
| .update_policy(uid, ¶ms.object_id, AFAccessLevel::FullAccess) |
There was a problem hiding this comment.
If batch_insert_collabs should work on batches, should that for loop be a batch as well?
There was a problem hiding this comment.
yes. it should be. Because shuheng is working on access control. So I don't want to modify the access control. I will leave a todo for myself
appflowy
force-pushed
the
optimize_batch_collab_write
branch
from
e85a682
to
026fae7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.