Update Noble #219
Closed
Update Noble #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you, honestly I would more love to switch to https://github.com/stoprocent/noble/ fork because more uptodate, prebuild works again and several enhancbements for UART based ble devices ... ok, your typing change would be needed to add there. Could I ask you to do that please as PR? I will then support to get it merged |
|
Awesome, thank you! |
|
@dnicolson Did you had a chance to test and verify it still works? If yes I would release it tomorrow, else next week because I'm out some days |
|
@Apollon77 I haven't been able to test it. I'm only really sure about the initial change, to be honest. |
|
All right. I release next week |
|
I merged manually and included your updates, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes abandonware/noble#327 and abandonware/noble#328.