perf: move no-capture check to the inside of the ConfigWrapper cons…

…tructor; avoid when only `--help` (#2376)

src/ape/pytest/config.py

@@ -27,6 +27,18 @@ class ConfigWrapper(ManagerAccessMixin):
 
     def __init__(self, pytest_config: "PytestConfig"):
         self.pytest_config = pytest_config
+        if not self.verbosity:
+            # Enable verbose output if stdout capture is disabled
+            self.verbosity = self.pytest_config.getoption("capture") == "no"
+        # else: user has already changes verbosity to an equal or higher level; avoid downgrading.
+
+    @property
+    def verbosity(self) -> int:
+        return self.pytest_config.option.verbose
+
+    @verbosity.setter
+    def verbosity(self, value):
+        self.pytest_config.option.verbose = value
 
     @cached_property
     def supports_tracing(self) -> bool:

src/ape/pytest/plugin.py

@@ -68,11 +68,6 @@ def is_module(v):
                 except AttributeError:
                     pass
 
-    if not config.option.verbose:
-        # Enable verbose output if stdout capture is disabled
-        config.option.verbose = config.getoption("capture") == "no"
-    # else: user has already changes verbosity to an equal or higher level; avoid downgrading.
-
     if "--help" in config.invocation_params.args:
         # perf: Don't bother setting up runner if only showing help.
         return

tests/functional/test_test.py

@@ -3,6 +3,7 @@
 import pytest
 
 from ape.exceptions import ConfigError
+from ape.pytest.config import ConfigWrapper
 from ape.pytest.runners import PytestApeRunner
 from ape_test import ApeTestConfig
 from ape_test._watch import run_with_observer
@@ -18,6 +19,32 @@ def test_balance_set_from_currency_str(self):
         assert actual == expected
 
 
+class TestConfigWrapper:
+    def test_verbosity(self, mocker):
+        """
+        Show it returns the same as pytest_config's.
+        """
+        pytest_cfg = mocker.MagicMock()
+        pytest_cfg.option.verbose = False
+        wrapper = ConfigWrapper(pytest_cfg)
+        assert wrapper.verbosity is False
+
+    def test_verbosity_when_no_capture(self, mocker):
+        """
+        Shows we enable verbose output when no-capture is set.
+        """
+
+        def get_opt(name: str):
+            return "no" if name == "capture" else None
+
+        pytest_cfg = mocker.MagicMock()
+        pytest_cfg.option.verbose = False  # Start off as False
+        pytest_cfg.getoption.side_effect = get_opt
+
+        wrapper = ConfigWrapper(pytest_cfg)
+        assert wrapper.verbosity is True
+
+
 def test_connect_to_mainnet_by_default(mocker):
     """
     Tests the condition where mainnet is configured as the default network