Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playlist update only introduce fields to change #246

Open
AntonioMrtz opened this issue Oct 6, 2024 · 5 comments · May be fixed by #289
Open

Playlist update only introduce fields to change #246

AntonioMrtz opened this issue Oct 6, 2024 · 5 comments · May be fixed by #289
Assignees
Labels
backend Backend related issues good first issue Good for newcomers help-wanted Help is wanted python Pull requests that update Python code refactor Code changes or improvements that do not change code behaviour

Comments

@AntonioMrtz
Copy link
Owner

Description

We want playlist update method to only need as parameters the fields that are going to change. Separate logic for adding and removing songs into two new other endpoints and methods

Context

Frontend is required to fetch playlist data and then send a request to update playlist data, that includes both data that won't change and data that has to change

How to do it

  • Create add songs to playlist
  • Create delete songs from playlist
  • Update playlist rename to update_playlist_metadata. This will only require the parameters that the user want to change( Ex: no need to provide photo if you don't want to change it). The allowed fields to change with this method will be: new_name, description and photo
  • Adapt frontend @AntonioMrtz

Testing

  • Create tests for all new methods
  • Adapt update playlist tests to fit update_playlist_metadata requirements
@AntonioMrtz AntonioMrtz added good first issue Good for newcomers backend Backend related issues refactor Code changes or improvements that do not change code behaviour help-wanted Help is wanted python Pull requests that update Python code labels Oct 6, 2024
@AntonioMrtz
Copy link
Owner Author

@KristianLengyel
Copy link

KristianLengyel commented Oct 8, 2024

Hello @AntonioMrtz is it possible to contribute to this issue ? I see that it is interesting topic and problem to solve.

@AntonioMrtz
Copy link
Owner Author

AntonioMrtz commented Oct 9, 2024

Hi @KristianLengyel , all yours. Thanks for your time, we have a docs website for doing the set up and other related topics. If you find this project interesting/helpful, I'd appreciate it if you could star the repo! .Let me know if you need anything :)

@KristianLengyel
Copy link

Just a little heads up, I'm just setting up the environment and familiarizing myself with the docs. I'll start working on the issue shortly. If I have any questions, I'll reach out.

@AntonioMrtz
Copy link
Owner Author

Yeah @KristianLengyel , no problem , take all the time you need, there's no need to hurry. Feel free to ask if you think I can help you with anything :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Backend related issues good first issue Good for newcomers help-wanted Help is wanted python Pull requests that update Python code refactor Code changes or improvements that do not change code behaviour
Projects
None yet
2 participants